Sign upLogin

luyadev/luya-module-cms

View on GitHub
Star
src/models/NavItemPageBlockItem.php

Summary

Maintainability
B
4 hrs
Test Coverage
D
62%

Function ensureInputValues has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    protected function ensureInputValues($event)
    {
        // sort index fixture

        if (!$this->isNewRecord) {
Severity: Minor
Found in src/models/NavItemPageBlockItem.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function rules has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public function rules()
    {
        return [
            [['json_config_values', 'json_config_cfg_values'], function ($attribute, $params) {
                // if its not an array, the attribute is not dirty and has not to be serialized from input.
Severity: Minor
Found in src/models/NavItemPageBlockItem.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ensureInputValues has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function ensureInputValues($event)
    {
        // sort index fixture

        if (!$this->isNewRecord) {
Severity: Minor
Found in src/models/NavItemPageBlockItem.php - About 1 hr to fix

    Function deleteAllSubBlocks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        private function deleteAllSubBlocks($blockId)
    {
        if ($blockId) {
            $subBlocks = NavItemPageBlockItem::findAll(['prev_id' => $blockId]);
            foreach ($subBlocks as $block) {
    Severity: Minor
    Found in src/models/NavItemPageBlockItem.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status