Sign upLogin

luyadev/luya-module-cms

View on GitHub
Star
tests/src/base/InternalBaseBlockTest.php

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testVarAppendingOfVars()
    {
        $block = new TestBlock();
        $block->addVar(['var' => 'append', 'label' => 'test', 'type' => 'zaa-text'], true);
        $block->addVar(['var' => 'append2', 'label' => 'test2', 'type' => 'zaa-text'], true);
Severity: Major
Found in tests/src/base/InternalBaseBlockTest.php and 3 other locations - About 2 hrs to fix
tests/src/base/InternalBaseBlockTest.php on lines 28..36
tests/src/base/InternalBaseBlockTest.php on lines 38..46
tests/src/base/InternalBaseBlockTest.php on lines 48..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testVarNotAppendingOfVars()
    {
        $block = new TestBlock();
        $block->addVar(['var' => 'append', 'label' => 'test', 'type' => 'zaa-text'], false);
        $block->addVar(['var' => 'append2', 'label' => 'test2', 'type' => 'zaa-text'], false);
Severity: Major
Found in tests/src/base/InternalBaseBlockTest.php and 3 other locations - About 2 hrs to fix
tests/src/base/InternalBaseBlockTest.php on lines 18..26
tests/src/base/InternalBaseBlockTest.php on lines 38..46
tests/src/base/InternalBaseBlockTest.php on lines 48..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testCfgAppendingOfVars()
    {
        $block = new TestBlock();
        $block->addCfg(['var' => 'append', 'label' => 'test', 'type' => 'zaa-text'], true);
        $block->addCfg(['var' => 'append2', 'label' => 'test2', 'type' => 'zaa-text'], true);
Severity: Major
Found in tests/src/base/InternalBaseBlockTest.php and 3 other locations - About 2 hrs to fix
tests/src/base/InternalBaseBlockTest.php on lines 18..26
tests/src/base/InternalBaseBlockTest.php on lines 28..36
tests/src/base/InternalBaseBlockTest.php on lines 48..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    public function testCfgNotAppendingOfVars()
    {
        $block = new TestBlock();
        $block->addCfg(['var' => 'append', 'label' => 'test', 'type' => 'zaa-text'], false);
        $block->addCfg(['var' => 'append2', 'label' => 'test2', 'type' => 'zaa-text'], false);
Severity: Major
Found in tests/src/base/InternalBaseBlockTest.php and 3 other locations - About 2 hrs to fix
tests/src/base/InternalBaseBlockTest.php on lines 18..26
tests/src/base/InternalBaseBlockTest.php on lines 28..36
tests/src/base/InternalBaseBlockTest.php on lines 38..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 127.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status