Sign upLogin

luyadev/luya-module-forms

View on GitHub
Star

Showing 12 of 12 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * Message translations.
 *
 * This file is automatically generated by 'yii message/extract' command.
Severity: Major
Found in src/messages/pt/forms.php and 1 other location - About 2 days to fix
src/messages/en/forms.php on lines 1..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 465.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * Message translations.
 *
 * This file is automatically generated by 'yii message/extract' command.
Severity: Major
Found in src/messages/en/forms.php and 1 other location - About 2 days to fix
src/messages/pt/forms.php on lines 1..112

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 465.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method save has 56 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function save(Form $form, $doNotSave = false)
    {
        $model = new Submission();
        $model->form_id = $form->id;
        $model->useragent = Yii::$app->request->userAgent;
Severity: Major
Found in src/Forms.php - About 2 hrs to fix

    Function save has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function save(Form $form, $doNotSave = false)
    {
        $model = new Submission();
        $model->form_id = $form->id;
        $model->useragent = Yii::$app->request->userAgent;
    Severity: Minor
    Found in src/Forms.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method safeUp has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function safeUp()
    {
        $this->createTable('{{%forms_form}}', [
            'id' => $this->primaryKey(),
            'title' => $this->text()->notNull(),
    Severity: Minor
    Found in src/migrations/m200910_114548_basetables.php - About 1 hr to fix

      Method config has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function config()
    {
        return [
            'vars' => [
                [
      Severity: Minor
      Found in src/blocks/FormBlock.php - About 1 hr to fix

        Function submitAndStore has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

            public function submitAndStore()
    {
        if ($this->isSubmit()) {
            // the data is only available if the isSubmit call was running, therefore for
            // first check for is submit
        Severity: Minor
        Found in src/blocks/FormBlock.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function callbackExport has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function callbackExport()
    {
        $data = [];

        $keys = false;
        Severity: Minor
        Found in src/aws/ExportActiveWindow.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method config has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function config()
    {
        return ArrayHelper::merge([
            'vars' => [
                [
        Severity: Minor
        Found in src/blocks/SelectBlock.php - About 1 hr to fix

          Method frontend has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function frontend()
    {
        Yii::$app->forms->autoConfigureAttribute(
            $this->getVarValue($this->varAttribute),
            $this->getVarValue($this->varRule, $this->defaultRule),
          Severity: Minor
          Found in src/blocks/CheckboxesBlock.php - About 1 hr to fix

            Method callbackExport has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function callbackExport()
    {
        $data = [];

        $keys = false;
            Severity: Minor
            Found in src/aws/ExportActiveWindow.php - About 1 hr to fix

              Method autoConfigureAttribute has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function autoConfigureAttribute($attributeName, $rule, $isRequired, $label = null, $hint = null, $formatAs = null)
              Severity: Minor
              Found in src/Forms.php - About 45 mins to fix
                Severity
                Category
                Status
                Source
                Language