luyadev/luya

View on GitHub

Showing 82 of 90 total issues

Function _unmonitorIntersections has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    IntersectionObserver.prototype._unmonitorIntersections = function(doc) {
      var index = this._monitoringDocuments.indexOf(doc);
      if (index == -1) {
        return;
      }
Severity: Minor
Found in core/resources/lazyload/intersectionObserver.polyfill.src.js - About 1 hr to fix

    Function smtpTest has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function smtpTest($verbose)
        {
            //Create a new SMTP instance
            $smtp = new SMTP();
            
    Severity: Minor
    Found in core/components/Mail.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function loadThemeConfig has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function loadThemeConfig(string $basePath)
        {
            if (strpos($basePath, '@') === 0) {
                $dir = Yii::getAlias($basePath);
            } elseif (strpos($basePath, '/') === 0) {
    Severity: Minor
    Found in core/theme/ThemeManager.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getConfigArray has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getConfigArray()
        {
            if ($this->_configArray === null) {
                if (!file_exists($this->configFile)) {
                    if (!$this->getIsCli()) {
    Severity: Minor
    Found in core/base/Boot.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getThemeDefinitions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function getThemeDefinitions()
        {
            $themeDefinitions = [];
            
            if (file_exists(Yii::getAlias('@app/themes'))) {
    Severity: Minor
    Found in core/theme/ThemeManager.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function run($app)
        {
            if (!$app->request->getIsConsoleRequest()) {
                if ($this->hasModule('admin') && $app->request->isAdmin) {
                    // When admin context, change csrf token, this will not terminate the frontend csrf token:
    Severity: Minor
    Found in core/web/Bootstrap.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method applicationConsole has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function applicationConsole()
        {
            $this->setIsCli(true);
            $config = $this->getConfigArray();
            $config['defaultRoute'] = 'help';
    Severity: Minor
    Found in core/base/Boot.php - About 1 hr to fix

      Method behaviors has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function behaviors()
          {
              $behaviors = parent::behaviors();
      
              if ($this->enableCors) {
      Severity: Minor
      Found in core/traits/RestBehaviorsTrait.php - About 1 hr to fix

        Method generateClassName has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function generateClassName($tableName, $useSchemaName = null)
            {
                if (isset($this->classNames[$tableName])) {
                    return $this->classNames[$tableName];
                }
        Severity: Minor
        Found in core/console/commands/BaseCrudController.php - About 1 hr to fix

          Function getDirectoryFiles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getDirectoryFiles($folderName)
              {
                  $files = [];
                  if (array_key_exists($folderName, $this->_dirs)) {
                      foreach ($this->_dirs[$folderName] as $folder) {
          Severity: Minor
          Found in core/console/commands/ImportController.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function toArray has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              public function toArray($envs = [])
              {
                  $config = [];
                  $envs = (array) $envs;
                  $envs = array_merge($envs, [self::ENV_ALL]);
          Severity: Minor
          Found in core/Config.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method parseRequest has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function parseRequest($request)
              {
                  // extra data from request to composition, which changes the pathInfo of the Request-Object.
                  $resolver = $this->getComposition()->getResolvedPathInfo($request);
          
          
          Severity: Minor
          Found in core/web/UrlManager.php - About 1 hr to fix

            Function appendConfig has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                private function appendConfig(&$config, ConfigDefinition $definition)
                {
                    switch ($definition->getGroup()) {
                        case ConfigDefinition::GROUP_APPLICATIONS:
                            foreach ($definition->getConfig() as $k => $v) {
            Severity: Minor
            Found in core/Config.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function generateLabels has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function generateLabels($table)
                {
                    $labels = [];
                    foreach ($table->columns as $column) {
                        if ($this->generateLabelsFromComments && !empty($column->comment)) {
            Severity: Minor
            Found in core/console/commands/BaseCrudController.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function urlReplaceModule has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                private function urlReplaceModule($url, $navItemId, Composition $composition)
                {
                    $route = $composition->removeFrom($this->removeBaseUrl($url));
                    $moduleName = $this->findModuleInRoute($route);
                
            Severity: Minor
            Found in core/web/UrlManager.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validateAttribute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                public function validateAttribute($model, $attribute)
                {
                    $value = $model->{$attribute};
                    
                    if ($this->length && strlen($value) < $this->length) {
            Severity: Minor
            Found in core/validators/StrengthValidator.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                          if (!crossOriginRect ||
                              crossOriginRect.width == 0 && crossOriginRect.height == 0) {
                            // A 0-size cross-origin intersection means no-intersection.
                            parent = null;
                            parentRect = null;
            Severity: Major
            Found in core/resources/lazyload/intersectionObserver.polyfill.src.js - About 45 mins to fix

              Function extractModules has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function extractModules($app)
                  {
                      if ($this->_modules === null) {
                          foreach ($app->getModules() as $id => $obj) {
                              // create module object
              Severity: Minor
              Found in core/base/BaseBootstrap.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function processText has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function processText($text)
                  {
                      // verify if content is a string otherwhise just return the original provided content
                      if (!is_string($text) || empty($text)) {
                          return $text;
              Severity: Minor
              Found in core/TagParser.php - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function init has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function init()
                  {
                      $path = Yii::getAlias($this->configFile);
                      if (file_exists($path)) {
                          $config = (include($path));
              Severity: Minor
              Found in core/web/Element.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language