luyadev/luya

View on GitHub

Showing 133 of 133 total issues

File XLSXWriter.php has 1035 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace luya\helpers;

use ZipArchive;
Severity: Major
Found in core/helpers/XLSXWriter.php - About 2 days to fix

    File CreativeWorkTrait.php has 686 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace luya\web\jsonld;
    
    use luya\helpers\ObjectHelper;
    Severity: Major
    Found in core/web/jsonld/CreativeWorkTrait.php - About 1 day to fix

      Function numberFormatStandardized has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
      Open

          private static function numberFormatStandardized($num_format)
          {
              if ($num_format == 'money') {
                  $num_format = 'dollar';
              }
      Severity: Minor
      Found in core/helpers/XLSXWriter.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function styleFontIndexes has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function styleFontIndexes()
          {
              static $border_allowed = array('left', 'right', 'top', 'bottom');
              static $border_style_allowed = array(
                  'thin',
      Severity: Minor
      Found in core/helpers/XLSXWriter.php - About 7 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File OrganizationTrait.php has 465 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      namespace luya\web\jsonld;
      
      /**
      Severity: Minor
      Found in core/web/jsonld/OrganizationTrait.php - About 7 hrs to fix

        File PersonTrait.php has 458 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        
        namespace luya\web\jsonld;
        
        use luya\helpers\ObjectHelper;
        Severity: Minor
        Found in core/web/jsonld/PersonTrait.php - About 7 hrs to fix

          XLSXWriter has 41 functions (exceeds 20 allowed). Consider refactoring.
          Open

          class XLSXWriter
          {
              //http://www.ecma-international.org/publications/standards/Ecma-376.htm
              //http://officeopenxml.com/SSstyles.php
              //------------------------------------------------------------------
          Severity: Minor
          Found in core/helpers/XLSXWriter.php - About 5 hrs to fix

            Method writeStylesXML has 123 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                protected function writeStylesXML()
                {
                    $r = self::styleFontIndexes();
                    $fills = $r['fills'];
                    $fonts = $r['fonts'];
            Severity: Major
            Found in core/helpers/XLSXWriter.php - About 4 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if (isset($style['border-color']) && is_string($style['border-color']) && $style['border-color'][0] == '#') {
                                  $v = substr($style['border-color'], 1, 6);
                                  $v = strlen($v) == 3 ? $v[0] . $v[0] . $v[1] . $v[1] . $v[2] . $v[2] : $v;// expand cf0 => ccff00
                                  $border_value['color'] = "FF" . strtoupper($v);
                              }
              Severity: Major
              Found in core/helpers/XLSXWriter.php and 1 other location - About 4 hrs to fix
              core/helpers/XLSXWriter.php on lines 574..578

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 150.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if (isset($style['color']) && is_string($style['color']) && $style['color'][0] == '#') {
                              $v = substr($style['color'], 1, 6);
                              $v = strlen($v) == 3 ? $v[0] . $v[0] . $v[1] . $v[1] . $v[2] . $v[2] : $v;// expand cf0 => ccff00
                              $font['color'] = "FF" . strtoupper($v);
                          }
              Severity: Major
              Found in core/helpers/XLSXWriter.php and 1 other location - About 4 hrs to fix
              core/helpers/XLSXWriter.php on lines 519..523

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 150.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function generateRules has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function generateRules($table)
                  {
                      $types = [];
                      $lengths = [];
                      foreach ($table->columns as $column) {
              Severity: Minor
              Found in core/console/commands/BaseCrudController.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function generateContentArray has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected static function generateContentArray($contentRows, array $keys, $generateHeader = true)
                  {
                      if (is_scalar($contentRows)) {
                          throw new Exception("Content must be either an array, object or traversable.");
                      }
              Severity: Minor
              Found in core/helpers/ExportHelper.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function writeStylesXML has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function writeStylesXML()
                  {
                      $r = self::styleFontIndexes();
                      $fills = $r['fills'];
                      $fonts = $r['fonts'];
              Severity: Minor
              Found in core/helpers/XLSXWriter.php - About 4 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function textToSpeech has 106 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  $.textToSpeech = function(options) {
                      var settings = $.extend(
                          {
                              text: '',
                              playEvent: 'textToSpeech:play',
              Severity: Major
              Found in core/resources/texttospeech/texttospeech.src.js - About 4 hrs to fix

                File PlaceTrait.php has 335 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                <?php
                
                namespace luya\web\jsonld;
                
                /**
                Severity: Minor
                Found in core/web/jsonld/PlaceTrait.php - About 4 hrs to fix

                  Method styleFontIndexes has 98 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function styleFontIndexes()
                      {
                          static $border_allowed = array('left', 'right', 'top', 'bottom');
                          static $border_style_allowed = array(
                              'thin',
                  Severity: Major
                  Found in core/helpers/XLSXWriter.php - About 3 hrs to fix

                    Method initializeSheet has 96 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function initializeSheet(
                            $sheet_name,
                            $col_widths = array(),
                            $auto_filter = false,
                            $freeze_rows = false,
                    Severity: Major
                    Found in core/helpers/XLSXWriter.php - About 3 hrs to fix

                      Function run has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function run($app)
                          {
                              if (!$app->request->getIsConsoleRequest()) {
                                  if ($this->hasModule('admin') && $app->request->isAdmin) {
                                      // When admin context, change csrf token, this will not terminate the frontend csrf token:
                      Severity: Minor
                      Found in core/web/Bootstrap.php - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function actionInit has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                      Open

                          public function actionInit()
                          {
                              // username
                              $username = $this->getConfig(self::CONFIG_VAR_USERNAME);
                              if (!$username) {
                      Severity: Minor
                      Found in dev/RepoController.php - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method generateRules has 80 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function generateRules($table)
                          {
                              $types = [];
                              $lengths = [];
                              foreach ($table->columns as $column) {
                      Severity: Major
                      Found in core/console/commands/BaseCrudController.php - About 3 hrs to fix
                        Severity
                        Category
                        Status
                        Source
                        Language