luyadev/luya

View on GitHub

Showing 131 of 141 total issues

Function filterMatch has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Confirmed

    public static function filterMatch($value, $conditions, $caseSensitive = true)
    {
        if (is_scalar($conditions)) {
            $conditions = self::explode($conditions, ",", true, true);
        }
Severity: Minor
Found in core/helpers/StringHelper.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generateLabels has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    public function generateLabels($table)
    {
        $labels = [];
        foreach ($table->columns as $column) {
            if ($this->generateLabelsFromComments && !empty($column->comment)) {
Severity: Minor
Found in core/console/commands/BaseCrudController.php - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function urlReplaceModule has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private function urlReplaceModule($url, $navItemId, Composition $composition)
    {
        $route = $composition->removeFrom($this->removeBaseUrl($url));
        $moduleName = $this->findModuleInRoute($route);
    
Severity: Minor
Found in core/web/UrlManager.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function folderToZip has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    private static function folderToZip($folder, &$zipFile, $exclusiveLength)
    {
        $handle = opendir($folder);
        while (false !== $f = readdir($handle)) {
            if ($f != '.' && $f != '..') {
Severity: Minor
Found in core/helpers/ZipHelper.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validateAttribute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function validateAttribute($model, $attribute)
    {
        $value = $model->{$attribute};
        
        if ($this->length && strlen($value) < $this->length) {
Severity: Minor
Found in core/validators/StrengthValidator.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

              if (!crossOriginRect ||
                  crossOriginRect.width == 0 && crossOriginRect.height == 0) {
                // A 0-size cross-origin intersection means no-intersection.
                parent = null;
                parentRect = null;
Severity: Major
Found in core/resources/lazyload/intersectionObserver.polyfill.src.js - About 45 mins to fix

    Method writeCell has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            XLSXWriter_BuffererWriter &$file,
            $row_number,
            $column_number,
            $value,
            $num_format_type,
    Severity: Minor
    Found in core/helpers/XLSXWriter.php - About 45 mins to fix

      Function writeToFile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function writeToFile($filename)
          {
              foreach ($this->sheets as $sheet_name => $sheet) {
                  self::finalizeSheet($sheet_name);//making sure all footers have been written
              }
      Severity: Minor
      Found in core/helpers/XLSXWriter.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function extractModules has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function extractModules($app)
          {
              if ($this->_modules === null) {
                  foreach ($app->getModules() as $id => $obj) {
                      // create module object
      Severity: Minor
      Found in core/base/BaseBootstrap.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function processText has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          private function processText($text)
          {
              // verify if content is a string otherwhise just return the original provided content
              if (!is_string($text) || empty($text)) {
                  return $text;
      Severity: Minor
      Found in core/TagParser.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initializeSheet has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $sheet_name,
              $col_widths = array(),
              $auto_filter = false,
              $freeze_rows = false,
              $freeze_columns = false
      Severity: Minor
      Found in core/helpers/XLSXWriter.php - About 35 mins to fix

        Method markMergedCell has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function markMergedCell($sheet_name, $start_cell_row, $start_cell_column, $end_cell_row, $end_cell_column)
        Severity: Minor
        Found in core/helpers/XLSXWriter.php - About 35 mins to fix

          Method truncateMiddle has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static function truncateMiddle($content, $word, $length, $affix = '..', $caseSensitive = false)
          Severity: Minor
          Found in core/helpers/StringHelper.php - About 35 mins to fix

            Function getThemes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getThemes($throwException = false)
                {
                    if ($this->_themes) {
                        return $this->_themes;
                    }
            Severity: Minor
            Found in core/theme/ThemeManager.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function run has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function run($app)
                {
                    foreach ($app->getApplicationModules() as $id => $module) {
                        $folder = $module->basePath . DIRECTORY_SEPARATOR . 'commands';
                        if (file_exists($folder) && is_dir($folder)) {
            Severity: Minor
            Found in core/console/Bootstrap.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function behaviors has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function behaviors()
                {
                    $behaviors = parent::behaviors();
            
                    if (!$this->getUserAuthClass()) {
            Severity: Minor
            Found in core/traits/RestBehaviorsTrait.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function init has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function init()
                {
                    $path = Yii::getAlias($this->configFile);
                    if (file_exists($path)) {
                        $config = (include($path));
            Severity: Minor
            Found in core/web/Element.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getControllers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public static function getControllers(Module $module)
                {
                    $files = [];
            
                    try { // https://github.com/yiisoft/yii2/blob/master/framework/base/Module.php#L253
            Severity: Minor
            Found in core/helpers/ObjectHelper.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function logValueToTable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function logValueToTable(array $logs)
                {
                    $table = new Table();
                    $table->setHeaders(['Key', 'Value']);
                    $rows = [];
            Severity: Minor
            Found in core/console/commands/ImportController.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getExceptionArray has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getExceptionArray($exception)
                {
                    $_message = 'Uknonwn exception object, not instance of \Exception.';
                    $_file = 'unknown';
                    $_line = 0;
            Severity: Minor
            Found in core/traits/ErrorHandlerTrait.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language