Sign upLogin

lyfeyaj/poplar

View on GitHub
Star

Showing 53 of 53 total issues

Function toResult has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

ApiMethod.toResult = function(raw, presenter, presenterSource, options) {
  if (Entity.isEntity(presenter)) {
    var result = presenter.parse(_eval(raw, presenterSource), options, _convert);
    return _eval(raw, presenterSource, result);
  } else {
Severity: Major
Found in lib/api_method.js - About 2 hrs to fix

    Function applyDelegates has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    HttpContext.prototype.applyDelegates = function(method) {
  var proto = this;
  /**
 * Response delegation.
 */
    Severity: Major
    Found in lib/contexts/http.js - About 2 hrs to fix

      Function Validate has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function Validate(params, accepts) {

  var validationError = new ValidationError();
  params = params || {};
  accepts = accepts || [];
      Severity: Major
      Found in lib/validation.js - About 2 hrs to fix

        Function done has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        HttpContext.prototype.done = function() {
  // if response is already returned, then do nothing
  if (this._done) return;
        Severity: Major
        Found in lib/contexts/http.js - About 2 hrs to fix

          Function coerceAccepts has 40 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function coerceAccepts(uarg, desc) {
  var name = desc.name || desc.arg;
  var targetType = convertToBasicType(desc.type);
  var targetTypeIsArray = _.isArray(targetType) && targetType.length === 1;
          Severity: Minor
          Found in lib/api_method.js - About 1 hr to fix

            Function Sanitize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function Sanitize(params, accepts) {
  params = params || {};
  accepts = accepts || [];

  _.each(accepts, function(accept) {
            Severity: Minor
            Found in lib/sanitizer.js - About 1 hr to fix

              Function use has 36 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              Poplar.prototype.use = function(name, options) {
  var apiBuilder = name;

  if (!(apiBuilder instanceof ApiBuilder)) {
    apiBuilder = new ApiBuilder(name, options);
              Severity: Minor
              Found in lib/poplar.js - About 1 hr to fix

                Function errorHandler has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                RestAdapter.errorHandler = function(options) {
  options = options || {};
  return function restErrorHandler(err, req, res, next) {
    if (typeof options.errorHandler === 'function') {
      try {
                Severity: Minor
                Found in lib/adapters/rest.js - About 1 hr to fix

                  Function execHooks has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                  Open

                  Poplar.prototype.execHooks = function(when, method, ctx, next) {
  var methodName = method.fullName();

  // change state
  var currentState = util.format('%s.%s', when, methodName);
                  Severity: Minor
                  Found in lib/poplar.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function restErrorHandler has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    return function restErrorHandler(err, req, res, next) {
    if (typeof options.errorHandler === 'function') {
      try {
        options.errorHandler(err, req, res, next);
      } catch (e) {
                  Severity: Minor
                  Found in lib/adapters/rest.js - About 1 hr to fix

                    Function coerceAll has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                    Open

                    function coerceAll(obj) {
  var type = Array.isArray(obj) ? 'array' : typeof obj;
  var i;
  var n;
                    Severity: Minor
                    Found in lib/contexts/http.js - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _eval has 31 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      function _eval(source, path, value) {
    if (path && _.isString(path)) {

      // split path by '[', '.', ']' and then remove empty string
      var list = _.compact(path.trim().split(/\[|\.|\]/));
                    Severity: Minor
                    Found in lib/api_method.js - About 1 hr to fix

                      Function execHooks has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      Poplar.prototype.execHooks = function(when, method, ctx, next) {
  var methodName = method.fullName();

  // change state
  var currentState = util.format('%s.%s', when, methodName);
                      Severity: Minor
                      Found in lib/poplar.js - About 1 hr to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        [
  'blacklist',
  'escape',
  'ltrim',
  'normalizeEmail',
                        Severity: Major
                        Found in lib/sanitizer.js and 1 other location - About 1 hr to fix
                        lib/validation.js on lines 22..69

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 57.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        [
  'contains',
  'equals',
  'isAfter',
  'isAlpha',
                        Severity: Major
                        Found in lib/validation.js and 1 other location - About 1 hr to fix
                        lib/sanitizer.js on lines 22..42

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 57.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Function parse has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                        Entity.prototype.parse = function(input, options, converter) {
  debug('parsing %j with options %j and converter', input, options);
  var originalObj;
  var result = {};
  var self = this;
                        Severity: Minor
                        Found in lib/entity.js - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function ApiMethod has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        function ApiMethod(name, options, fn) {

  this.__original = [name, options, fn];

  this.fn = fn;
                        Severity: Minor
                        Found in lib/api_method.js - About 1 hr to fix

                          Function performValidator has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                            var performValidator = function(name, val, validatorOpts, validatorName) {
    validatorOpts = validatorOpts || {};

    // if validator is a custom function, then execute it
    // else find cooresponding validator in built in Validator
                          Severity: Minor
                          Found in lib/validation.js - About 1 hr to fix

                            Function getType has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                            Open

                            ApiMethod.getType = function(val) {
  var type = typeof val;

  switch (type) {
    case 'undefined':
                            Severity: Minor
                            Found in lib/api_method.js - About 55 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function createHandler has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                            Open

                            RestAdapter.prototype.createHandler =  function() {
  var router = express.Router(this.options);
  var adapter = this;
  var methods = this.api.allMethods();
                            Severity: Minor
                            Found in lib/adapters/rest.js - About 55 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language