Sign upLogin

mLewisLogic/saddle

View on GitHub
Star
lib/saddle/middleware/request/url_encoded.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method has_multipart? has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        def has_multipart?(obj)
          # string is an enum in 1.8, returning list of itself
          if obj.respond_to?(:each) && !obj.is_a?(String)
            (obj.respond_to?(:values) ? obj.values : obj).each do |val|
              return true if (val.respond_to?(:content_type) || has_multipart?(val))
Severity: Minor
Found in lib/saddle/middleware/request/url_encoded.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method call has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        def call(env)
          if env[:saddle][:request_style] == :urlencoded
            # Make sure we're working with a valid body that's not a String
            if env[:body] and !env[:body].respond_to?(:to_str)
              if has_multipart?(env[:body])
Severity: Minor
Found in lib/saddle/middleware/request/url_encoded.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method process_params has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def process_params(params, prefix = nil, pieces = nil, &block)
          params.inject(pieces || []) do |all, (key, value)|
            key = "#{prefix}[#{key}]" if prefix

            case value
Severity: Minor
Found in lib/saddle/middleware/request/url_encoded.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status