Sign upLogin

mLewisLogic/saddle

View on GitHub
Star
lib/saddle/requester.rb

Summary

Maintainability
B
7 hrs
Test Coverage

Method initialize has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(parent_client, opt={})
      # We may want properties about the parent client in middlewares
      @parent_client = parent_client
      # Store the options for later use
      @options = opt
Severity: Minor
Found in lib/saddle/requester.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def initialize(parent_client, opt={})
      # We may want properties about the parent client in middlewares
      @parent_client = parent_client
      # Store the options for later use
      @options = opt
Severity: Minor
Found in lib/saddle/requester.rb - About 1 hr to fix

    Method connection has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def connection
      @connection ||= Faraday.new(base_url, :builder_class => Saddle::RackBuilder) do |connection|
        # Include the requester level options
        connection.builder.saddle_options[:client_options] = @options
    Severity: Minor
    Found in lib/saddle/requester.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status