Sign upLogin

maa123/mastodon

View on GitHub
Star
app/javascript/mastodon/components/status_content.jsx

Summary

Maintainability
D
2 days
Test Coverage

Function render has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  render () {
    const { status, intl, statusContent } = this.props;

    const hidden = this.props.onExpandedToggle ? !this.props.expanded : this.state.hidden;
    const renderReadMore = this.props.onClick && status.get('collapsed');
Severity: Minor
Found in app/javascript/mastodon/components/status_content.jsx - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render () {
    const { status, intl, statusContent } = this.props;

    const hidden = this.props.onExpandedToggle ? !this.props.expanded : this.state.hidden;
    const renderReadMore = this.props.onClick && status.get('collapsed');
Severity: Major
Found in app/javascript/mastodon/components/status_content.jsx - About 2 hrs to fix

    Function _updateStatusLinks has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _updateStatusLinks () {
    const node = this.node;

    if (!node) {
      return;
    Severity: Minor
    Found in app/javascript/mastodon/components/status_content.jsx - About 1 hr to fix

      Function _updateStatusLinks has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        _updateStatusLinks () {
    const node = this.node;

    if (!node) {
      return;
      Severity: Minor
      Found in app/javascript/mastodon/components/status_content.jsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        onHashtagClick = (hashtag, e) => {
    hashtag = hashtag.replace(/^#/, '');

    if (this.context.router && e.button === 0 && !(e.ctrlKey || e.metaKey)) {
      e.preventDefault();
      Severity: Major
      Found in app/javascript/mastodon/components/status_content.jsx and 1 other location - About 4 hrs to fix
      app/javascript/mastodon/features/getting_started/components/announcements.jsx on lines 98..105

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 115.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        onMentionClick = (mention, e) => {
    if (this.context.router && e.button === 0 && !(e.ctrlKey || e.metaKey)) {
      e.preventDefault();
      this.context.router.history.push(`/@${mention.get('acct')}`);
    }
      Severity: Major
      Found in app/javascript/mastodon/components/status_content.jsx and 1 other location - About 3 hrs to fix
      app/javascript/mastodon/features/getting_started/components/announcements.jsx on lines 91..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 10 locations. Consider refactoring.
      Open

        handleMouseLeave = ({ currentTarget }) => {
    if (autoPlayGif) {
      return;
    }
      Severity: Major
      Found in app/javascript/mastodon/components/status_content.jsx and 9 other locations - About 3 hrs to fix
      app/javascript/mastodon/components/status_content.jsx on lines 141..152
      app/javascript/mastodon/features/account/components/header.jsx on lines 132..143
      app/javascript/mastodon/features/account/components/header.jsx on lines 145..156
      app/javascript/mastodon/features/direct_timeline/components/conversation.jsx on lines 50..61
      app/javascript/mastodon/features/direct_timeline/components/conversation.jsx on lines 63..74
      app/javascript/mastodon/features/directory/components/account_card.jsx on lines 112..123
      app/javascript/mastodon/features/directory/components/account_card.jsx on lines 125..136
      app/javascript/mastodon/features/getting_started/components/announcements.jsx on lines 114..125
      app/javascript/mastodon/features/getting_started/components/announcements.jsx on lines 127..138

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 10 locations. Consider refactoring.
      Open

        handleMouseEnter = ({ currentTarget }) => {
    if (autoPlayGif) {
      return;
    }
      Severity: Major
      Found in app/javascript/mastodon/components/status_content.jsx and 9 other locations - About 3 hrs to fix
      app/javascript/mastodon/components/status_content.jsx on lines 154..165
      app/javascript/mastodon/features/account/components/header.jsx on lines 132..143
      app/javascript/mastodon/features/account/components/header.jsx on lines 145..156
      app/javascript/mastodon/features/direct_timeline/components/conversation.jsx on lines 50..61
      app/javascript/mastodon/features/direct_timeline/components/conversation.jsx on lines 63..74
      app/javascript/mastodon/features/directory/components/account_card.jsx on lines 112..123
      app/javascript/mastodon/features/directory/components/account_card.jsx on lines 125..136
      app/javascript/mastodon/features/getting_started/components/announcements.jsx on lines 114..125
      app/javascript/mastodon/features/getting_started/components/announcements.jsx on lines 127..138

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 97.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            } else if (link.textContent[0] === '#' || (link.previousSibling && link.previousSibling.textContent && link.previousSibling.textContent[link.previousSibling.textContent.length - 1] === '#')) {
        link.addEventListener('click', this.onHashtagClick.bind(this, link.text), false);
        link.setAttribute('href', `/tags/${link.text.replace(/^#/, '')}`);
      } else {
        link.setAttribute('title', link.href);
      Severity: Major
      Found in app/javascript/mastodon/components/status_content.jsx and 2 other locations - About 1 hr to fix
      app/javascript/mastodon/features/account/components/header.jsx on lines 214..218
      app/javascript/mastodon/features/getting_started/components/announcements.jsx on lines 75..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 70.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status