Sign upLogin

maa123/mastodon

View on GitHub
Star
lib/mastodon/cli/upgrade.rb

Summary

Maintainability
C
1 day
Test Coverage

Method storage_schema has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
Open

    def storage_schema
      progress = create_progress_bar(nil)
      records  = 0

      klasses = [
Severity: Minor
Found in lib/mastodon/cli/upgrade.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method upgrade_storage_filesystem has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def upgrade_storage_filesystem(progress, attachment, style)
      previous_storage_schema_version = attachment.storage_schema_version
      previous_path                   = attachment.path(style)
      success                         = true
Severity: Minor
Found in lib/mastodon/cli/upgrade.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method storage_schema has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def storage_schema
      progress = create_progress_bar(nil)
      records  = 0

      klasses = [
Severity: Minor
Found in lib/mastodon/cli/upgrade.rb - About 1 hr to fix

    Method upgrade_storage_filesystem has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def upgrade_storage_filesystem(progress, attachment, style)
      previous_storage_schema_version = attachment.storage_schema_version
      previous_path                   = attachment.path(style)
      success                         = true
    Severity: Minor
    Found in lib/mastodon/cli/upgrade.rb - About 1 hr to fix

      Method upgrade_storage_s3 has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def upgrade_storage_s3(progress, attachment, style)
      previous_storage_schema_version = attachment.storage_schema_version
      object                          = attachment.s3_object(style)
      success                         = true
      Severity: Minor
      Found in lib/mastodon/cli/upgrade.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status