Showing 29 of 29 total issues
Function SwaggerManager
has a Cognitive Complexity of 147 (exceeds 5 allowed). Consider refactoring. Open
var SwaggerManager = function(options) {
options = options || {};
var swaggerHooks = options.swaggerHooks || {};
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function RouteSchemaManager
has a Cognitive Complexity of 124 (exceeds 5 allowed). Consider refactoring. Open
var RouteSchemaManager = function(options) {
options = options || {};
var schemasByServerUri = {},
validationTypes = {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function SwaggerManager
has 313 lines of code (exceeds 25 allowed). Consider refactoring. Open
var SwaggerManager = function(options) {
options = options || {};
var swaggerHooks = options.swaggerHooks || {};
Function RouteSchemaManager
has 237 lines of code (exceeds 25 allowed). Consider refactoring. Open
var RouteSchemaManager = function(options) {
options = options || {};
var schemasByServerUri = {},
validationTypes = {
Function RequestValidator
has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring. Open
var RequestValidator = function(plugin, options) {
options = options || {};
var configuredErrorReporters = Hoek.applyToDefaults(errorReporters, options.errorReporters || {});
var routeSchemaManager = new RouteSchemaManager({ pluginName: options.pluginName, log: options.log }),
log = options.log || function(){},
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File SwaggerManager.js
has 318 lines of code (exceeds 250 allowed). Consider refactoring. Open
var _ = require('lodash'),
fs = require('fs');
var SwaggerManager = function(options) {
Function getSwaggerParams
has 63 lines of code (exceeds 25 allowed). Consider refactoring. Open
getSwaggerParams = function(route, type, operationNickname) {
var params = [], prop, param;
if (swaggerParamTypeMap[type] &&
route.settings.plugins &&
route.settings.plugins[options.pluginName] &&
Function RequestValidator
has 61 lines of code (exceeds 25 allowed). Consider refactoring. Open
var RequestValidator = function(plugin, options) {
options = options || {};
var configuredErrorReporters = Hoek.applyToDefaults(errorReporters, options.errorReporters || {});
var routeSchemaManager = new RouteSchemaManager({ pluginName: options.pluginName, log: options.log }),
log = options.log || function(){},
Function getApiDeclarationModel
has 54 lines of code (exceeds 25 allowed). Consider refactoring. Open
this.getApiDeclarationModel = function(routes, apiName) {
var cached = apiDocsCache[apiName];
if (cached){
return cached;
}
Function getSwaggerOperationForRoute
has 53 lines of code (exceeds 25 allowed). Consider refactoring. Open
getSwaggerOperationForRoute = function(route, resourceType, path) {
var pathParts = path.split('/'),
regex = /^\{.+\}$/,
lastPart = pathParts.pop(),
resourceId = (regex.test(lastPart)) ? lastPart : null,
Consider simplifying this complex logical expression. Open
if (forceArrayConversion && schema.type === 'array' && typeof(object) === 'string' && schema.items &&
(schema.items.type === 'string' || schema.items.type === 'number' || schema.items.type === 'integer' || schema.items.type === 'boolean')) {
object = [object];
}
Function register
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports.register = function (plugin, options, next) {
var settings = Hoek.applyToDefaults(defaults, options || {}),
swaggerManager = new SwaggerManager(settings);
Similar blocks of code found in 2 locations. Consider refactoring. Open
if(model.oneOf && Array.isArray(model.oneOf) && model.oneOf.length > 0) {
model = model.oneOf[0];
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (schema.oneOf &&
Array.isArray(schema.oneOf) &&
schema.oneOf.length > 0) {
schema = schema.oneOf[0];
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function onPostHandler
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
onPostHandler = function(request, reply) {
var report, errorMessages;
// if route config contains a schema for the respose, and sample rate is greater than 0, validate it
if (request.route.settings.plugins &&
Function convertPropertyTypesToMatchSchema
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
convertPropertyTypesToMatchSchema = function(object, schema, forceArrayConversion) {
// in some cases (query params), we want to force a value to be an array that contains that value,
// if the schema expects an array of strings, numbers, integers, or booleans
if (forceArrayConversion && schema.type === 'array' && typeof(object) === 'string' && schema.items &&
(schema.items.type === 'string' || schema.items.type === 'number' || schema.items.type === 'integer' || schema.items.type === 'boolean')) {
Avoid deeply nested control flow statements. Open
if (schema.properties[prop].hasOwnProperty('items')) {
param.items = schema.properties[prop].items;
}
Avoid deeply nested control flow statements. Open
for (i = 0; i < object.length; i++) {
object[i] = convertPropertyTypesToMatchSchema(object[i], schema.items, forceArrayConversion);
}
Avoid deeply nested control flow statements. Open
if (schema.properties[prop].hasOwnProperty('enum')) {
param.enum = schema.properties[prop].enum;
}
Avoid deeply nested control flow statements. Open
if (schema.properties.hasOwnProperty(prop)) {
var formParam = {
paramType: 'form',
name: prop,
description: schema.properties[prop].description,