Sign upLogin

mac-/ratify

View on GitHub
Star
lib/RequestValidator.js

Summary

Maintainability
C
1 day
Test Coverage

Function RequestValidator has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

var RequestValidator = function(plugin, options) {
    options = options || {};
    var configuredErrorReporters = Hoek.applyToDefaults(errorReporters, options.errorReporters || {});
    var routeSchemaManager = new RouteSchemaManager({ pluginName: options.pluginName, log: options.log }),
        log = options.log || function(){},
Severity: Minor
Found in lib/RequestValidator.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function RequestValidator has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var RequestValidator = function(plugin, options) {
    options = options || {};
    var configuredErrorReporters = Hoek.applyToDefaults(errorReporters, options.errorReporters || {});
    var routeSchemaManager = new RouteSchemaManager({ pluginName: options.pluginName, log: options.log }),
        log = options.log || function(){},
Severity: Major
Found in lib/RequestValidator.js - About 2 hrs to fix

    Function onPostHandler has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            onPostHandler = function(request, reply) {
            var report, errorMessages;

            // if route config contains a schema for the respose, and sample rate is greater than 0, validate it
            if (request.route.settings.plugins &&
    Severity: Minor
    Found in lib/RequestValidator.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

                  if (request.route.settings.plugins &&
                request.route.settings.plugins[options.pluginName] &&
                request.route.settings.plugins[options.pluginName].response &&
                request.route.settings.plugins[options.pluginName].response.schema &&
                request.route.settings.plugins[options.pluginName].response.sample !== 0 &&
      Severity: Major
      Found in lib/RequestValidator.js - About 40 mins to fix

        There are no issues that match your filters.

        Category
        Status