madbob/GASdottoNG

View on GitHub
code/resources/assets/js/gasdotto.js

Summary

Maintainability
D
3 days
Test Coverage

File gasdotto.js has 597 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*******************************************************************************
    Varie ed eventuali
*/

window.$ = window.jQuery = global.$ = global.jQuery = require('jquery');
Severity: Major
Found in code/resources/assets/js/gasdotto.js - About 1 day to fix

    Function miscInnerCallbacks has 121 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function miscInnerCallbacks(form, data) {
        if (locker == true) {
            return false;
        }
    
    
    Severity: Major
    Found in code/resources/assets/js/gasdotto.js - About 4 hrs to fix

      Function generalInit has 73 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function generalInit(container) {
          if (container == null) {
              container = $('body');
          }
      
      
      Severity: Major
      Found in code/resources/assets/js/gasdotto.js - About 2 hrs to fix

        Function miscInnerCallbacks has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        function miscInnerCallbacks(form, data) {
            if (locker == true) {
                return false;
            }
        
        
        Severity: Minor
        Found in code/resources/assets/js/gasdotto.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function completionRowsInit has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function completionRowsInit(node) {
            $(node).find('input:text').each(function() {
                if ($(this).hasClass('ui-autocomplete-input') == true) {
                    return;
                }
        Severity: Minor
        Found in code/resources/assets/js/gasdotto.js - About 1 hr to fix

          Function enforceMeasureDiscrete has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function enforceMeasureDiscrete(node) {
              var form = node.closest('form');
              var selected = node.find('option:selected').val();
              var discrete = measure_discrete[selected];
              var disabled = (discrete == '1');
          Severity: Minor
          Found in code/resources/assets/js/gasdotto.js - About 1 hr to fix

            Function generalInit has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            function generalInit(container) {
                if (container == null) {
                    container = $('body');
                }
            
            
            Severity: Minor
            Found in code/resources/assets/js/gasdotto.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function enforceMeasureDiscrete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function enforceMeasureDiscrete(node) {
                var form = node.closest('form');
                var selected = node.find('option:selected').val();
                var discrete = measure_discrete[selected];
                var disabled = (discrete == '1');
            Severity: Minor
            Found in code/resources/assets/js/gasdotto.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            success: function(data) {
                                var upper = Lists.closeParent(form);
                                var list = upper.closest('.loadable-list');
                                upper.remove();
                                Lists.testListsEmptiness(list);
            Severity: Minor
            Found in code/resources/assets/js/gasdotto.js and 1 other location - About 55 mins to fix
            code/resources/assets/js/callables.js on lines 318..323

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                utils.j().submitButton(form).each(function() {
                                    utils.inlineFeedback($(this), _('Salvato!'));
                                });
            Severity: Minor
            Found in code/resources/assets/js/gasdotto.js and 1 other location - About 50 mins to fix
            code/resources/assets/js/utils.js on lines 190..192

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 51.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status