Sign upLogin

madbob/GASdottoNG

View on GitHub
Star

Showing 495 of 495 total issues

Function run has a Cognitive Complexity of 116 (exceeds 5 allowed). Consider refactoring.
Open

    public function run($request)
    {
        DB::beginTransaction();

        list($reader, $columns) = $this->initRead($request);
Severity: Minor
Found in code/app/Importers/CSV/Users.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace App\Parameters\MovementType;

use App\Movement;
Severity: Major
Found in code/app/Parameters/MovementType/AnnualFee.php and 1 other location - About 1 day to fix
code/app/Parameters/MovementType/DepositPay.php on lines 1..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 321.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace App\Parameters\MovementType;

use App\MovementType as MovementTypeModel;
Severity: Major
Found in code/app/Parameters/MovementType/DepositPay.php and 1 other location - About 1 day to fix
code/app/Parameters/MovementType/AnnualFee.php on lines 1..57

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 321.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File Order.php has 651 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace App;

use Illuminate\Database\Eloquent\Model;
Severity: Major
Found in code/app/Order.php - About 1 day to fix

    Function select has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
    Open

        public function select($request)
    {
        $user = Auth::user();
        $service = app()->make('BookingsService');
        $errors = [];
    Severity: Minor
    Found in code/app/Importers/CSV/Deliveries.php - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File gasdotto.js has 605 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*******************************************************************************
    Varie ed eventuali
*/

window.$ = window.jQuery = global.$ = global.jQuery = require('jquery');
    Severity: Major
    Found in code/resources/assets/js/gasdotto.js - About 1 day to fix

      Function select has a Cognitive Complexity of 63 (exceeds 5 allowed). Consider refactoring.
      Open

          public function select($request)
    {
        list($reader, $columns) = $this->initRead($request);
        $target_separator = ',';
      Severity: Minor
      Found in code/app/Importers/CSV/Movements.php - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File Booking.php has 506 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

namespace App;

use Illuminate\Database\Eloquent\Model;
      Severity: Major
      Found in code/app/Booking.php - About 1 day to fix

        Method run has 192 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function run()
    {
        $gas = Gas::where('name', '!=', '')->first();

        $gas->name = 'GAS Demo';
        Severity: Major
        Found in code/database/seeders/DemoSeeder.php - About 7 hrs to fix

          Function updateBookingQuantities has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
          Open

              static updateBookingQuantities(dynamic_data, container, action)
    {
        for (let [product_id, product_meta] of Object.entries(dynamic_data)) {
            var inputbox = $('input[name="' + product_id + '"]', container);
            inputbox.closest('tr').find('.booking-product-price span').text(utils.priceRound(product_meta.total));
          Severity: Minor
          Found in code/resources/assets/js/bookings.js - About 7 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function init has 183 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              static init(container)
    {
        $('.bookingSearch', container).each((index, item) => {
            var input = $(item);
          Severity: Major
          Found in code/resources/assets/js/bookings.js - About 7 hrs to fix

            Function select has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
            Open

                public function select($request)
    {
        list($reader, $columns) = $this->initRead($request);
        list($name_index, $supplier_code_index) = $this->getColumnsIndex($columns, ['name', 'supplier_code']);
        $s = $this->getSupplier($request);
            Severity: Minor
            Found in code/app/Importers/CSV/Products.php - About 6 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getDates has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
            Open

                private function getDates()
    {
        $dates = Date::where('type', 'order')->get();
        $today = date('Y-m-d');
        $aggregable = [];
            Severity: Minor
            Found in code/app/Console/Commands/OpenOrders.php - About 6 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Order has 47 functions (exceeds 20 allowed). Consider refactoring.
            Open

            class Order extends Model
{
    use HasFactory, TracksUpdater, AttachableTrait, ExportableTrait, ModifiableTrait, PayableTrait, CreditableTrait, GASModel, SluggableID, ReducibleTrait;

    public $incrementing = false;
            Severity: Minor
            Found in code/app/Order.php - About 6 hrs to fix

              Function formatProduct has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function formatProduct($fields, $formattable, $product_redux, $product, $internal_offsets)
    {
        $ret = [];

        if (is_null($product_redux) == false) {
              Severity: Minor
              Found in code/app/Printers/Concerns/Orders.php - About 6 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Booking has 44 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Booking extends Model
{
    use HasFactory, GASModel, SluggableID, TracksUpdater, ModifiedTrait, PayableTrait, CreditableTrait, ReducibleTrait, Cachable;

    public $incrementing = false;
              Severity: Minor
              Found in code/app/Booking.php - About 6 hrs to fix

                Function handleShipping has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                Open

                    protected function handleShipping($obj, $request)
    {
        $subtype = $request['format'] ?? 'pdf';
        $required_fields = $request['fields'] ?? [];
                Severity: Minor
                Found in code/app/Printers/Aggregate.php - About 5 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function init has 147 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    static init(container)
    {
        this.handlingContactSelection(container);
        this.initDatesWidgets(container);
                Severity: Major
                Found in code/resources/assets/js/widgets.js - About 5 hrs to fix

                  Function apply has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function apply($modifier, $booking, $aggregate_data)
    {
        if ($modifier->active == false) {
            Log::debug('Modificatore non attivo, ignoro applicazione');
            return null;
                  Severity: Minor
                  Found in code/app/Singletons/ModifierEngine.php - About 5 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function readBooking has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                  Open

                      private function readBooking(array $request, $order, $booking, $delivering)
    {
        $param = $this->handlingParam($delivering);

        if (isset($request['notes_' . $order->id])) {
                  Severity: Minor
                  Found in code/app/Services/BookingsService.php - About 5 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language