madbob/GASdottoNG

View on GitHub

Showing 437 of 494 total issues

Avoid deeply nested control flow statements.
Open

                            if ($(this).text().toLowerCase().indexOf(text) != -1) {
                                display = true;
                                return false;
                            }
Severity: Major
Found in code/resources/assets/js/filters.js - About 45 mins to fix

    Function filesForSupplier has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private function filesForSupplier($order)
        {
            $printer = new OrderPrinter();
    
            $type = $order->supplier->notify_on_close_enabled;
    Severity: Minor
    Found in code/app/Jobs/NotifyClosedOrder.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getValue has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getValue($type)
        {
            $ret = 0;
    
            if (Str::startsWith($type, 'modifier:')) {
    Severity: Minor
    Found in code/app/BookedProduct.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function updateOrders has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        public function updateOrders(array $request)
        {
            $user = $this->ensureAuth(['supplier.orders' => null]);
            $suppliers = array_keys($user->targetsByAction('supplier.orders'));
    
    
    Severity: Minor
    Found in code/app/Services/DatesService.php - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if (varinputbox.length == 0) {
                                break;
                            }
    Severity: Major
    Found in code/resources/assets/js/bookings.js - About 45 mins to fix

      Function handle has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function handle()
          {
              $order = Order::find($this->order_id);
      
              if (is_null($order)) {
      Severity: Minor
      Found in code/app/Jobs/NotifyNewOrder.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                              for (let i = product_meta.variants.length; i < total_rows.length; i++) {
                                  let varinputbox = total_rows.eq(i);
                                  varinputbox.val(0);
                                  varinputbox.closest('tr').find('.booking-product-price span').text('0.00');
                              }
      Severity: Major
      Found in code/resources/assets/js/bookings.js - About 45 mins to fix

        Function verifyConsistency has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            private function verifyConsistency($movement)
            {
                $metadata = $movement->type_metadata;
        
                if (is_null($metadata)) {
        Severity: Minor
        Found in code/app/Observers/MovementObserver.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function sortedContraints has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function sortedContraints($only_mandatory = false)
            {
                $constraints = systemParameters('Constraints');
        
                $sorted_contraints = [
        Severity: Minor
        Found in code/app/Parameters/Constraints/Constraint.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function iban_split has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function iban_split($iban, $field)
        {
            switch($field) {
                case 'country':
                    $start = 0;
        Severity: Minor
        Found in code/app/Helpers/Formatters.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getCalendarStringAttribute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getCalendarStringAttribute()
            {
                if($this->type == 'internal') {
                    return $this->description;
                }
        Severity: Minor
        Found in code/app/Date.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getOrderDatesAttribute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getOrderDatesAttribute()
            {
                $ret = [];
        
                if ($this->type != 'order') {
        Severity: Minor
        Found in code/app/Date.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function saved has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function saved(Config $config)
            {
                switch($config->name) {
                    case 'integralces':
                        $value = json_decode($config->value);
        Severity: Minor
        Found in code/app/Observers/ConfigObserver.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function detachProduct has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function detachProduct($product)
            {
                $altered_bookings = 0;
        
                /*
        Severity: Minor
        Found in code/app/Order.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function formatDateToComponent has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function formatDateToComponent($component, $params)
        {
            $mandatory = $params['required'];
        
            $defaults_now = $params['attributes']['defaults_now'] ?? false;
        Severity: Minor
        Found in code/app/Helpers/Components.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function handleSave has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function handleSave($gas, $request)
            {
                $satispay_info = null;
        
                if ($request->has('enable_satispay')) {
        Severity: Minor
        Found in code/app/Parameters/Config/Satispay.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function show has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function show(Request $request, $aggregate_id, $user_id)
            {
                $user = User::findOrFail($user_id);
                $aggregate = Aggregate::findOrFail($aggregate_id);
        
        
        Severity: Minor
        Found in code/app/Http/Controllers/BookingUserController.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method createBookingQuery has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private function createBookingQuery($query, $type, $start, $end, $target, $supplier)
        Severity: Minor
        Found in code/app/Http/Controllers/StatisticsController.php - About 45 mins to fix

          Function initCollectionMacros has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private function initCollectionMacros()
              {
                  /*
                      Questa va usata solo per una Collection di BookedProductVariant,
                      come ad esempio la relazione variants() di BookedProduct
          Severity: Minor
          Found in code/app/Providers/AppServiceProvider.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getAllDatesAttribute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public function getAllDatesAttribute()
              {
                  if (empty($this->recurring)) {
                      return [$this->date];
                  }
          Severity: Minor
          Found in code/app/Date.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language