madbob/GASdottoNG

View on GitHub

Showing 437 of 494 total issues

Method getOrderDatesAttribute has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getOrderDatesAttribute()
    {
        $ret = [];

        if ($this->type != 'order') {
Severity: Minor
Found in code/app/Date.php - About 1 hr to fix

    Method allPermissions has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function allPermissions()
    {
        $ret = [
            'App\Gas' => [
                'gas.access' => _i('Accesso consentito anche in manutenzione'),
    Severity: Minor
    Found in code/app/Helpers/Permissions.php - About 1 hr to fix

      Method computeStrings has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function computeStrings()
          {
              $names = [];
              $dates = [];
      
      
      Severity: Minor
      Found in code/app/Aggregate.php - About 1 hr to fix

        Method importJSON has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function importJSON($master, $json, $replace)
            {
                if (is_null($replace)) {
                    $supplier = new Supplier();
                    $supplier->payment_method = '';
        Severity: Minor
        Found in code/app/Importers/GDXP/Suppliers.php - About 1 hr to fix

          Function miscInnerCallbacks has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          function miscInnerCallbacks(form, data) {
              if (locker == true) {
                  return false;
              }
          
          
          Severity: Minor
          Found in code/resources/assets/js/gasdotto.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function postStatusSendinblue has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public function postStatusSendinblue(Request $request)
              {
                  if (env('MAIL_MAILER') == 'sendinblue') {
                      /*
                          Nota bene: qui arrivano tutte le segnalazioni webhook generate
          Severity: Minor
          Found in code/app/Http/Controllers/MailController.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function movementTypes has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

          function movementTypes($identifier = null, $with_trashed = false)
          {
              static $types = null;
          
              if ($identifier == 'VOID') {
          Severity: Minor
          Found in code/app/Helpers/Accounting.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function readDefinition has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              private static function readDefinition($modifier, $json)
              {
                  $definitions = [];
          
                  if (isset($json->fixed)) {
          Severity: Minor
          Found in code/app/Importers/GDXP/Transformations.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function roleInit has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              private function roleInit($gas)
              {
                  $queue = systemParameters('Roles');
          
                  while(true) {
          Severity: Minor
          Found in code/database/seeders/DatabaseSeeder.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function formatShipping has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

              public function formatShipping($order, $fields, $status, $shipping_place, $extra_modifiers)
              {
                  $ret = (object) [
                      'headers' => $fields->headers,
                      'contents' => [],
          Severity: Minor
          Found in code/app/Printers/Concerns/Shipping.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function initDatesWidgets has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              static initDatesWidgets(container)
              {
                  $('input.date', container).datepicker({
                      format: 'DD dd MM yyyy',
                      autoclose: true,
          Severity: Minor
          Found in code/resources/assets/js/widgets.js - About 1 hr to fix

            Method updateContacts has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function updateContacts($request)
                {
                    $ids = [];
                    $types = [];
                    $values = [];
            Severity: Minor
            Found in code/app/Models/Concerns/ContactableTrait.php - About 1 hr to fix

              Method formatProduct has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function formatProduct($fields, $formattable, $product_redux, $product, $internal_offsets)
                  {
                      $ret = [];
              
                      if (is_null($product_redux) == false) {
              Severity: Minor
              Found in code/app/Printers/Concerns/Orders.php - About 1 hr to fix

                Method getDates has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function getDates()
                    {
                        $dates = Date::where('type', 'order')->get();
                        $today = date('Y-m-d');
                        $aggregable = [];
                Severity: Minor
                Found in code/app/Console/Commands/OpenOrders.php - About 1 hr to fix

                  Method getSummary has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      private function getSummary($start, $end, $type, $target)
                      {
                          if ($type == 'all') {
                              $data = $this->basicSummaryForAll($start, $end, $target);
                          }
                  Severity: Minor
                  Found in code/app/Http/Controllers/StatisticsController.php - About 1 hr to fix

                    Method handleSummary has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        protected function handleSummary($obj, $request)
                        {
                            $subtype = $request['format'] ?? 'pdf';
                    
                            if ($subtype == 'gdxp') {
                    Severity: Minor
                    Found in code/app/Printers/Aggregate.php - About 1 hr to fix

                      Method commons has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public static function commons($user)
                          {
                              $ret = [];
                      
                              if ($user->can('users.admin', $user->gas)) {
                      Severity: Minor
                      Found in code/app/View/Icons/User.php - About 1 hr to fix

                        Method getProductsWithFriendsAttribute has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function getProductsWithFriendsAttribute()
                            {
                                return $this->innerCache('friends_products', function($obj) {
                                    /*
                                        Qui devo fare una copia di $this->products anziché usarlo
                        Severity: Minor
                        Found in code/app/Booking.php - About 1 hr to fix

                          Method updateAccessType has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              private function updateAccessType($id, $request)
                              {
                                  $user = Auth::user();
                                  if (is_null($user)) {
                                      throw new AuthException(401);
                          Severity: Minor
                          Found in code/app/Services/UsersService.php - About 1 hr to fix

                            Method update has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function update($id, array $request)
                                {
                                    $type = $this->updateAccessType($id, $request);
                                    if (is_object($type)) {
                                        return $type;
                            Severity: Minor
                            Found in code/app/Services/UsersService.php - About 1 hr to fix
                              Severity
                              Category
                              Status
                              Source
                              Language