Sign upLogin

madetech/market_town

View on GitHub
Star

Showing 53 of 53 total issues

OS Command Injection in Rake
Open

    rake (11.2.2)
Severity: Critical
Found in Gemfile.lock by bundler-audit

Advisory: CVE-2020-8130

Criticality: High

URL: https://github.com/advisories/GHSA-jppv-gw3r-w3q8

Solution: upgrade to >= 12.3.3

Block has too many lines. [142/25]
Open

  describe AddressStep do
    let(:fulfilments) do
      double(propose_shipments: nil,
             can_fulfil_shipments?: true,
             apply_shipment_costs: nil)
Severity: Minor
Found in checkout/spec/checkout/steps/address_step_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Arbitrary path traversal and file access via yard server
Open

    yard (0.8.7.6)
Severity: Critical
Found in Gemfile.lock by bundler-audit

Advisory: CVE-2019-1020001

Criticality: High

URL: https://github.com/lsegal/yard/security/advisories/GHSA-xfhh-rx56-rxcr

Solution: upgrade to >= 0.9.20

Possible arbitrary path traversal and file access via yard server
Open

    yard (0.8.7.6)
Severity: Minor
Found in Gemfile.lock by bundler-audit

Advisory:

URL: https://github.com/lsegal/yard/security/advisories/GHSA-xfhh-rx56-rxcr

Solution: upgrade to >= 0.9.20

Potential arbitrary file read vulnerability in yard server
Open

    yard (0.8.7.6)
Severity: Critical
Found in Gemfile.lock by bundler-audit

Advisory: CVE-2017-17042

Criticality: High

URL: https://nvd.nist.gov/vuln/detail/CVE-2017-17042

Solution: upgrade to >= 0.9.11

Block has too many lines. [96/25]
Open

  describe DeliveryStep do
    let(:fulfilments) do
      double(can_fulfil_shipments?: true,
             apply_shipment_costs: nil)
    end
Severity: Minor
Found in checkout/spec/checkout/steps/delivery_step_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [81/25]
Open

  shared_examples_for 'address step using spree-like container' do
    context 'when processing address step' do
      context 'and addresses valid' do
        let(:order) { order_upto_address }
Severity: Minor
Found in checkout/spec/checkout/integrations/spree_like/address_step.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [79/25]
Open

    context 'when processing address step' do
      context 'and addresses valid' do
        let(:order) { order_upto_address }

        before(:each) do
Severity: Minor
Found in checkout/spec/checkout/integrations/spree_like/address_step.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [54/25]
Open

  describe CompleteStep do
    let(:fulfilments) { double(fulfil: nil) }
    let(:notifications) { double(notify: nil) }
    let(:finish) { double(complete_step_finished?: false, complete_step: nil) }
Severity: Minor
Found in checkout/spec/checkout/steps/complete_step_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [41/25]
Open

  shared_examples_for 'cart step using spree-like container' do
    context 'when processing cart step' do
      context 'and the order has line items' do
        let(:order) { create(:order_with_totals) }
Severity: Minor
Found in checkout/spec/checkout/integrations/spree_like/cart_step.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [39/25]
Open

    context 'when processing cart step' do
      context 'and the order has line items' do
        let(:order) { create(:order_with_totals) }

        before(:each) do
Severity: Minor
Found in checkout/spec/checkout/integrations/spree_like/cart_step.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [36/25]
Open

  describe CartStep do
    let(:order) { double(has_line_items?: true) }
    let(:user_address_storage) { double(load_default_addresses: nil) }
    let(:finish) { double(cart_step: nil) }
Severity: Minor
Found in checkout/spec/checkout/steps/cart_step_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      context 'and address has non-existant country' do
        let(:order) { create(:order_with_totals) }
        let(:address_with_country) { mock_address.merge(country: 'DE') }

        subject do
Severity: Minor
Found in checkout/spec/checkout/integrations/spree_like/address_step.rb and 1 other location - About 45 mins to fix
checkout/spec/checkout/integrations/spree_like/address_step.rb on lines 77..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      context 'and address has non-existant region populated' do
        let(:order) { create(:order_with_totals) }
        let(:address_with_region) { mock_address.merge(region: 'Meh') }

        subject do
Severity: Minor
Found in checkout/spec/checkout/integrations/spree_like/address_step.rb and 1 other location - About 45 mins to fix
checkout/spec/checkout/integrations/spree_like/address_step.rb on lines 90..100

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Block has too many lines. [28/25]
Open

    context 'when processing address step' do
      context 'with valid addresses' do
        subject do
          step.process(billing_address: mock_address,
                       delivery_address: mock_address)
Severity: Minor
Found in checkout/spec/checkout/steps/address_step_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Block has too many lines. [28/25]
Open

  describe Contracts do
    let(:state) { {} }

    describe Contracts::UserAddressStorage do
      it_behaves_like 'UserAddressStorage'
Severity: Minor
Found in checkout/spec/checkout/contracts_spec.rb by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        shared_examples_for 'Order' do
          context '#has_line_items?' do
            subject { described_class.new.has_line_items?({}) }
            it_behaves_like 'a boolean query method'
          end
Severity: Minor
Found in checkout/lib/market_town/checkout/contracts/order.rb and 1 other location - About 20 mins to fix
checkout/lib/market_town/checkout/contracts/promotions.rb on lines 11..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        shared_examples_for 'Promotions' do
          context '#apply_cart_promotions' do
            subject { described_class.new.apply_cart_promotions({}) }
            it_behaves_like 'a command method'
          end
Severity: Minor
Found in checkout/lib/market_town/checkout/contracts/promotions.rb and 1 other location - About 20 mins to fix
checkout/lib/market_town/checkout/contracts/order.rb on lines 12..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      context 'and can apply them' do
        context 'then fulfilments' do
          before do
            step.process(billing_address: mock_address,
                         delivery_address: mock_address)
Severity: Minor
Found in checkout/spec/checkout/steps/address_step_spec.rb and 1 other location - About 15 mins to fix
checkout/spec/checkout/steps/address_step_spec.rb on lines 127..136

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      context 'and can fulfil' do
        context 'then fulfilments' do
          before do
            step.process(billing_address: mock_address,
                         delivery_address: mock_address)
Severity: Minor
Found in checkout/spec/checkout/steps/address_step_spec.rb and 1 other location - About 15 mins to fix
checkout/spec/checkout/steps/address_step_spec.rb on lines 159..168

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 25.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language