Sign upLogin

madetech/solidus_wms

View on GitHub
Star
solidus_wms.gemspec

Summary

Maintainability
Test Coverage

Block has too many lines. [30/25]
Open

Gem::Specification.new do |s|
  s.name        = 'solidus_wms'
  s.version     = SolidusWms::VERSION
  s.summary     = 'A WMS extension for solidus'
  s.description = 'Adds additional API endpoints, and state machine events to the `Spree::Shipment` to provide an integration with your WMS of choice.'
Severity: Minor
Found in solidus_wms.gemspec by rubocop

This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

Add an empty line after magic comments.
Open

$:.push File.expand_path('./lib', File.dirname(__FILE__))
Severity: Minor
Found in solidus_wms.gemspec by rubocop

Checks for a newline after the final magic comment.

Example:

# good
# frozen_string_literal: true

# Some documentation for Person
class Person
  # Some code
end

# bad
# frozen_string_literal: true
# Some documentation for Person
class Person
  # Some code
end

Unnecessary utf-8 encoding comment.
Open

# encoding: UTF-8
Severity: Minor
Found in solidus_wms.gemspec by rubocop

Dependencies should be sorted in an alphabetical order within their section of the gemspec. Dependency axlsx should appear before zip-zip.
Open

  s.add_dependency 'axlsx', '2.0.1'
Severity: Minor
Found in solidus_wms.gemspec by rubocop

Dependencies in the gemspec should be alphabetically sorted.

Example:

# bad
spec.add_dependency 'rubocop'
spec.add_dependency 'rspec'

# good
spec.add_dependency 'rspec'
spec.add_dependency 'rubocop'

# good
spec.add_dependency 'rubocop'

spec.add_dependency 'rspec'

# bad
spec.add_development_dependency 'rubocop'
spec.add_development_dependency 'rspec'

# good
spec.add_development_dependency 'rspec'
spec.add_development_dependency 'rubocop'

# good
spec.add_development_dependency 'rubocop'

spec.add_development_dependency 'rspec'

# bad
spec.add_runtime_dependency 'rubocop'
spec.add_runtime_dependency 'rspec'

# good
spec.add_runtime_dependency 'rspec'
spec.add_runtime_dependency 'rubocop'

# good
spec.add_runtime_dependency 'rubocop'

spec.add_runtime_dependency 'rspec'

# good only if TreatCommentsAsGroupSeparators is true
# For code quality
spec.add_dependency 'rubocop'
# For tests
spec.add_dependency 'rspec'

There are no issues that match your filters.

Category
Status