madhav-datt/kgp-hms

View on GitHub

Showing 63 of 63 total issues

Function setupUi has 533 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def setupUi(self, Form):
        Form.setObjectName(_fromUtf8("Form"))
        Form.resize(709, 455)
        self.stackedWidget = QtGui.QStackedWidget(Form)
        self.stackedWidget.setGeometry(QtCore.QRect(0, 0, 701, 461))
Severity: Major
Found in src/ui/warden_window.py - About 2 days to fix

    Function setupUi has 470 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def setupUi(self, Form):
            Form.setObjectName(_fromUtf8("Form"))
            Form.resize(630, 497)
            icon = QtGui.QIcon()
            icon.addPixmap(QtGui.QPixmap(_fromUtf8("../../../../../.designer/backup/logo2.png")), QtGui.QIcon.Normal, QtGui.QIcon.Off)
    Severity: Major
    Found in src/ui/HMC_Window.py - About 2 days to fix

      Function setupUi has 431 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def setupUi(self, Form):
              Form.setObjectName(_fromUtf8("Form"))
              Form.resize(581, 544)
              icon = QtGui.QIcon()
              icon.addPixmap(QtGui.QPixmap(_fromUtf8("../../Desktop/logo2.png")), QtGui.QIcon.Normal, QtGui.QIcon.Off)
      Severity: Major
      Found in src/ui/Student_Main_Window.py - About 2 days to fix

        File warden_window.py has 618 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # -*- coding: utf-8 -*-
        
        # Form implementation generated from reading ui file 'warden.ui'
        #
        # Created by: PyQt4 UI code generator 4.11.4
        Severity: Major
        Found in src/ui/warden_window.py - About 1 day to fix

          File HMC_Window.py has 561 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # -*- coding: utf-8 -*-
          
          # Form implementation generated from reading ui file 'HMC.ui'
          #
          # Created by: PyQt4 UI code generator 4.11.4
          Severity: Major
          Found in src/ui/HMC_Window.py - About 1 day to fix

            File Student_Main_Window.py has 517 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # -*- coding: utf-8 -*-
            
            # Form implementation generated from reading ui file 'Student_Main_Window.ui'
            #
            # Created by: PyQt4 UI code generator 4.11.4
            Severity: Major
            Found in src/ui/Student_Main_Window.py - About 1 day to fix

              Function setupUi has 196 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def setupUi(self, Form):
                      Form.setObjectName(_fromUtf8("Form"))
                      Form.resize(620, 415)
                      icon = QtGui.QIcon()
                      icon.addPixmap(QtGui.QPixmap(_fromUtf8("../../Desktop/logo2.png")), QtGui.QIcon.Normal, QtGui.QIcon.Off)
              Severity: Major
              Found in src/ui/Clerk_Window.py - About 7 hrs to fix

                Function setupUi has 194 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    def setupUi(self, Form):
                        Form.setObjectName(_fromUtf8("Form"))
                        Form.resize(545, 454)
                        self.stackedWidget = QtGui.QStackedWidget(Form)
                        self.stackedWidget.setGeometry(QtCore.QRect(-1, -1, 541, 451))
                Severity: Major
                Found in src/ui/Mess_Manager_Window.py - About 7 hrs to fix

                  Hall has 39 functions (exceeds 20 allowed). Consider refactoring.
                  Open

                  class Hall(object):
                      """Contains details of Hall
                  
                      Attributes:
                          hall_ID: Integer to uniquely identify hall
                  Severity: Minor
                  Found in src/halls/hall.py - About 5 hrs to fix

                    Function authenticate has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def authenticate(table, user_ID, password):
                        """
                        Authenticate login with entered user_ID and password
                        Check table to match and return True if correct
                        """
                    Severity: Minor
                    Found in src/database/login.py - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function password_validate has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def password_validate(self):
                            """
                            Check password for login
                            Set labels for various fields
                            """
                    Severity: Minor
                    Found in src/ui/Warden_GUI.py - About 4 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Cyclomatic complexity is too high in function rebuild. (19)
                    Open

                    def rebuild(table):
                        """
                        Rebuild object dictionary for specified table
                        """
                    
                    
                    Severity: Minor
                    Found in src/database/db_rebuild.py by radon

                    Cyclomatic Complexity

                    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                    Construct Effect on CC Reasoning
                    if +1 An if statement is a single decision.
                    elif +1 The elif statement adds another decision.
                    else +0 The else statement does not cause a new decision. The decision is at the if.
                    for +1 There is a decision at the start of the loop.
                    while +1 There is a decision at the while statement.
                    except +1 Each except branch adds a new conditional path of execution.
                    finally +0 The finally block is unconditionally executed.
                    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                    assert +1 The assert statement internally roughly equals a conditional statement.
                    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                    Source: http://radon.readthedocs.org/en/latest/intro.html

                    Cyclomatic complexity is too high in function authenticate. (18)
                    Open

                    def authenticate(table, user_ID, password):
                        """
                        Authenticate login with entered user_ID and password
                        Check table to match and return True if correct
                        """
                    Severity: Minor
                    Found in src/database/login.py by radon

                    Cyclomatic Complexity

                    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                    Construct Effect on CC Reasoning
                    if +1 An if statement is a single decision.
                    elif +1 The elif statement adds another decision.
                    else +0 The else statement does not cause a new decision. The decision is at the if.
                    for +1 There is a decision at the start of the loop.
                    while +1 There is a decision at the while statement.
                    except +1 Each except branch adds a new conditional path of execution.
                    finally +0 The finally block is unconditionally executed.
                    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                    assert +1 The assert statement internally roughly equals a conditional statement.
                    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                    Source: http://radon.readthedocs.org/en/latest/intro.html

                    Cyclomatic complexity is too high in method add_hall. (17)
                    Open

                        def add_hall(self):
                            """
                            Add ui elements for add hall tab
                            Create new hall
                            Assign warden, mess manager and hall office clerk
                    Severity: Minor
                    Found in src/ui/HMC_GUI.py by radon

                    Cyclomatic Complexity

                    Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                    Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                    Construct Effect on CC Reasoning
                    if +1 An if statement is a single decision.
                    elif +1 The elif statement adds another decision.
                    else +0 The else statement does not cause a new decision. The decision is at the if.
                    for +1 There is a decision at the start of the loop.
                    while +1 There is a decision at the while statement.
                    except +1 Each except branch adds a new conditional path of execution.
                    finally +0 The finally block is unconditionally executed.
                    with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                    assert +1 The assert statement internally roughly equals a conditional statement.
                    Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                    Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                    Source: http://radon.readthedocs.org/en/latest/intro.html

                    File HMC_GUI.py has 310 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    #
                    # IIT Kharagpur - Hall Management System
                    # System to manage Halls of residences, Warden grant requests, student complaints
                    # hall worker attendances and salary payments
                    #
                    Severity: Minor
                    Found in src/ui/HMC_GUI.py - About 3 hrs to fix

                      Function setupUi has 84 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          def setupUi(self, complaintWindow):
                              complaintWindow.setObjectName(_fromUtf8("complaintWindow"))
                              complaintWindow.setWindowModality(QtCore.Qt.ApplicationModal)
                              complaintWindow.resize(384, 441)
                              icon = QtGui.QIcon()
                      Severity: Major
                      Found in src/ui/Complaint.py - About 3 hrs to fix

                        Consider simplifying this complex logical expression.
                        Open

                                if name == "" or amenities_charge == 0. or single_room_count == 0 or single_room_rent == 0 \
                                        or double_room_count == 0 or double_room_rent == 0 or warden_name == "" or warden_pw == "" or \
                                        manager_name == "" or manager_pw == "" or manager_salary == 0. or clerk_name == "" or clerk_pw == "" \
                                        or clerk_salary == 0.:
                                    choice = QtGui.QMessageBox.question(self, 'Error', "No Field can be left blank")
                        Severity: Critical
                        Found in src/ui/HMC_GUI.py - About 3 hrs to fix

                          File Warden_GUI.py has 295 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          #
                          # IIT Kharagpur - Hall Management System
                          # System to manage Halls of residences, Warden grant requests, student complaints
                          # hall worker attendances and salary payments
                          #
                          Severity: Minor
                          Found in src/ui/Warden_GUI.py - About 3 hrs to fix

                            Cyclomatic complexity is too high in method password_validate. (13)
                            Open

                                def password_validate(self):
                                    """
                                    Check password for login
                                    Set labels for various fields
                                    """
                            Severity: Minor
                            Found in src/ui/Warden_GUI.py by radon

                            Cyclomatic Complexity

                            Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

                            Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

                            Construct Effect on CC Reasoning
                            if +1 An if statement is a single decision.
                            elif +1 The elif statement adds another decision.
                            else +0 The else statement does not cause a new decision. The decision is at the if.
                            for +1 There is a decision at the start of the loop.
                            while +1 There is a decision at the while statement.
                            except +1 Each except branch adds a new conditional path of execution.
                            finally +0 The finally block is unconditionally executed.
                            with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
                            assert +1 The assert statement internally roughly equals a conditional statement.
                            Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
                            Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

                            Source: http://radon.readthedocs.org/en/latest/intro.html

                            Function retranslateUi has 73 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                def retranslateUi(self, Form):
                                    Form.setWindowTitle(_translate("Form", "HMS - HMC Portal", None))
                                    self.label_33.setText(_translate("Form", "TextLabel", None))
                                    self.label_34.setText(_translate("Form", "WELCOME!", None))
                                    self.tabWidget.setTabText(self.tabWidget.indexOf(self.tab_1), _translate("Form", "Home", None))
                            Severity: Major
                            Found in src/ui/HMC_Window.py - About 2 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language