Sign upLogin

madkom/uri

View on GitHub
Star

Showing 14 of 14 total issues

Function parseQuery has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
Open

    protected function parseQuery(string $queryString, int $mode = self::MODE_QUERY_DUPLICATE_LAST) : Query
    {
        $query = new Query();
        $bracketsMatcher = new Matcher(new Pattern('^[^\[\]]+(\[[^\]]*\])+$'));
Severity: Minor
Found in src/UriFactory.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: mbrzuchalski
 * Date: 17.02.16
Severity: Major
Found in src/Component/Authority/Host/IPv4.php and 1 other location - About 3 hrs to fix
src/Component/Authority/Host/IPv6.php on lines 1..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php declare(strict_types=1);
/**
 * Created by PhpStorm.
 * User: mbrzuchalski
 * Date: 17.02.16
Severity: Major
Found in src/Component/Authority/Host/IPv6.php and 1 other location - About 3 hrs to fix
src/Component/Authority/Host/IPv4.php on lines 1..75

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 144.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function resolveUri has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    public function resolveUri(Uri $baseUri) : Uri
    {
        if (null !== $this->scheme) {
            $result = new Uri($this->scheme);
            $result->setAuthority($this->authority);
Severity: Minor
Found in src/UriReference.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parseQuery has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function parseQuery(string $queryString, int $mode = self::MODE_QUERY_DUPLICATE_LAST) : Query
    {
        $query = new Query();
        $bracketsMatcher = new Matcher(new Pattern('^[^\[\]]+(\[[^\]]*\])+$'));
Severity: Major
Found in src/UriFactory.php - About 2 hrs to fix

    Function createUri has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createUri(string $uriString, Scheme $defaultScheme = null) : Uri
    {
        $matcher = new Matcher($this->uriPattern);
        $match = $matcher->match($uriString);
        if ($match) {
    Severity: Minor
    Found in src/UriFactory.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function createUriReference has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function createUriReference(string $uriReferenceString) : UriReference
    {
        $matcher = new Matcher($this->uriPattern);
        $match = $matcher->match($uriReferenceString);
        if ($match) {
    Severity: Minor
    Found in src/UriFactory.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method resolveUri has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function resolveUri(Uri $baseUri) : Uri
    {
        if (null !== $this->scheme) {
            $result = new Uri($this->scheme);
            $result->setAuthority($this->authority);
    Severity: Minor
    Found in src/UriReference.php - About 1 hr to fix

      Function toString has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function toString(int $flags = 0) : string
    {
        $result = '';
        if ($this->scheme) {
            $result .= $this->scheme->toString() . ":";
      Severity: Minor
      Found in src/UriReference.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              Scheme $scheme = null,
        Authority $authority = null,
        Path $path = null,
        Query $query = null,
        Fragment $fragment = null
      Severity: Minor
      Found in src/UriReference.php - About 35 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                Scheme $scheme,
        Authority $authority = null,
        Path $path = null,
        Query $query = null,
        Fragment $fragment = null
        Severity: Minor
        Found in src/Uri.php - About 35 mins to fix

          Function toString has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function toString(int $flags = 0) : string
    {
        $result = '';
        if ($this->scheme) {
            $result .= $this->scheme->toString() . ":";
          Severity: Minor
          Found in src/Uri.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function parseAuthority has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function parseAuthority(string $authorityString) : Authority
    {
        $matcher = new Matcher($this->authorityPattern);
        $match = $matcher->match($authorityString);
        if ($match) {
          Severity: Minor
          Found in src/UriFactory.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function removeDotSegments has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function removeDotSegments() : Path
    {
        $result = clone $this;
        foreach ($result->segments as $index => $segment) {
            if ($segment == '.') {
          Severity: Minor
          Found in src/Component/Path.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language