Sign upLogin

maestrano/mno-enterprise

View on GitHub
Star
api/lib/mno_enterprise/concerns/controllers/deletion_requests_controller.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method freeze_account has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def freeze_account
    @deletion_request = current_user.deletion_request

    respond_to do |format|
      # Check that the user has a deletion_request in progress
Severity: Minor
Found in api/lib/mno_enterprise/concerns/controllers/deletion_requests_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method checkout has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def checkout
    @deletion_request = current_user.deletion_request

    respond_to do |format|
      # Check that the user has a deletion_request in progress
Severity: Minor
Found in api/lib/mno_enterprise/concerns/controllers/deletion_requests_controller.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method show has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

  def show
    # authorize! :manage_billing, current_user.organizations.find(@invoice.organization_id)
    @deletion_request = current_user.deletion_request

    respond_to do |format|
Severity: Minor
Found in api/lib/mno_enterprise/concerns/controllers/deletion_requests_controller.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status