Sign upLogin

maestrano/mno-enterprise

View on GitHub
Star
core/app/pdf/mno_enterprise/invoice_pdf.rb

Summary

Maintainability
D
2 days
Test Coverage

Method add_page_body has 260 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def add_page_body
      payment_enabled = !Settings.payment.disabled

      @pdf.stroke_color '999999'
Severity: Major
Found in core/app/pdf/mno_enterprise/invoice_pdf.rb - About 1 day to fix

    Method add_page_body has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

        def add_page_body
      payment_enabled = !Settings.payment.disabled

      @pdf.stroke_color '999999'
    Severity: Minor
    Found in core/app/pdf/mno_enterprise/invoice_pdf.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File invoice_pdf.rb has 385 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module MnoEnterprise
  class InvoicePdf
    include MnoEnterprise::ImageHelper
    attr_reader :invoice, :pdf, :data
    Severity: Minor
    Found in core/app/pdf/mno_enterprise/invoice_pdf.rb - About 5 hrs to fix

      Method initialize has 41 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def initialize(invoice)
      raise ArgumentError, "Received #{invoice.class} object (expected instance of Invoice)" unless invoice.is_a?(MnoEnterprise::Invoice)
      @invoice = invoice
      @pdf = nil
      @data = {}
      Severity: Minor
      Found in core/app/pdf/mno_enterprise/invoice_pdf.rb - About 1 hr to fix

        Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            def initialize(invoice)
      raise ArgumentError, "Received #{invoice.class} object (expected instance of Invoice)" unless invoice.is_a?(MnoEnterprise::Invoice)
      @invoice = invoice
      @pdf = nil
      @data = {}
        Severity: Minor
        Found in core/app/pdf/mno_enterprise/invoice_pdf.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status