Sign upLogin

maestrano/mno-enterprise

View on GitHub
Star
core/lib/her_extension/model/parse.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method to_params has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def to_params(attributes, changes = nil)
          filtered_attributes = attributes.dup.symbolize_keys
          filtered_attributes.merge!(embeded_params(attributes) || {})
          if her_api && her_api.options[:send_only_modified_attributes] && !changes.nil?
            filtered_attributes = changes.symbolize_keys.keys.inject({}) do |hash, attribute|
Severity: Minor
Found in core/lib/her_extension/model/parse.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method embeded_params has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def embeded_params(attributes)
          associations[:has_many].select { |a| attributes.include?(a[:data_key])}.compact.inject({}) do |hash, association|
            params = attributes[association[:data_key]].map(&:to_params)
            # <PATCH> - Return hash
            next hash if params.empty?
Severity: Minor
Found in core/lib/her_extension/model/parse.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status