Sign upLogin

maestrano/mno-enterprise

View on GitHub
Star
core/lib/mno_enterprise/concerns/controllers/auth/registrations_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method create has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    #  Filling the time at which TOS were accepted
    if params[:tos]
      params[:user][:meta_data] = {tos_accepted_at: Time.current}
    end
Severity: Minor
Found in core/lib/mno_enterprise/concerns/controllers/auth/registrations_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def create
    #  Filling the time at which TOS were accepted
    if params[:tos]
      params[:user][:meta_data] = {tos_accepted_at: Time.current}
    end
Severity: Minor
Found in core/lib/mno_enterprise/concerns/controllers/auth/registrations_controller.rb - About 1 hr to fix

    Method create_orga_on_user_creation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def create_orga_on_user_creation(user_attrs)
      return false unless user_attrs['email']

      # First check previous url to see if the user
      # was trying to accept an orga
    Severity: Minor
    Found in core/lib/mno_enterprise/concerns/controllers/auth/registrations_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status