Sign upLogin

maestrano/mno-enterprise

View on GitHub
Star
core/lib/mno_enterprise/testing_support/mno_enterprise_api_test_helper.rb

Summary

Maintainability
C
1 day
Test Coverage

Method api_stub_configure has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    def api_stub_configure(api)
      # This block should match the her.rb initializer
      api.setup MnoEnterprise.send(:api_options).merge(url: "http://localhost:65000") do |c|
        # Request
        c.use Faraday::Request::BasicAuthentication, MnoEnterprise.tenant_id, MnoEnterprise.tenant_key
Severity: Minor
Found in core/lib/mno_enterprise/testing_support/mno_enterprise_api_test_helper.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method api_stub_configure has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def api_stub_configure(api)
      # This block should match the her.rb initializer
      api.setup MnoEnterprise.send(:api_options).merge(url: "http://localhost:65000") do |c|
        # Request
        c.use Faraday::Request::BasicAuthentication, MnoEnterprise.tenant_id, MnoEnterprise.tenant_key
Severity: Minor
Found in core/lib/mno_enterprise/testing_support/mno_enterprise_api_test_helper.rb - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

          return res
    Severity: Major
    Found in core/lib/mno_enterprise/testing_support/mno_enterprise_api_test_helper.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return res.iso8601
      Severity: Major
      Found in core/lib/mno_enterprise/testing_support/mno_enterprise_api_test_helper.rb - About 30 mins to fix

        Method expand_options has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            def expand_options(opts)
      unless opts[:method] && opts[:path]
        [:get, :put, :post, :delete].each do |verb|
          if path = opts.delete(verb)
            opts[:path] = path
        Severity: Minor
        Found in core/lib/mno_enterprise/testing_support/mno_enterprise_api_test_helper.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status