Sign upLogin

maestro-server/analytics-maestro

View on GitHub
Star
app/tasks/enrichment_apps.py

Summary

Maintainability
A
35 mins
Test Coverage
F
45%

Function task_enrichment has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def task_enrichment(owner_id, graph_id, grid, index, edges):
Severity: Minor
Found in app/tasks/enrichment_apps.py - About 35 mins to fix

    Line too long (80 > 79 characters)
    Open

    from app.repository.externalMaestroOwneredData import ExternalMaestroOwneredData
    Severity: Minor
    Found in app/tasks/enrichment_apps.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Continuation line over-indented for visual indent
    Open

                        .list_request(path="servers", query=query)\
    Severity: Minor
    Found in app/tasks/enrichment_apps.py by pep8

    Continuation lines indentation.

    Continuation lines should align wrapped elements either vertically
using Python's implicit line joining inside parentheses, brackets
and braces, or using a hanging indent.

When using a hanging indent these considerations should be applied:
- there should be no arguments on the first line, and
- further indentation should be used to clearly distinguish itself
  as a continuation line.

Okay: a = (\n)
E123: a = (\n    )

Okay: a = (\n    42)
E121: a = (\n   42)
E122: a = (\n42)
E123: a = (\n    42\n    )
E124: a = (24,\n     42\n)
E125: if (\n    b):\n    pass
E126: a = (\n        42)
E127: a = (24,\n      42)
E128: a = (24,\n    42)
E129: if (a or\n    b):\n    pass
E131: a = (\n    42\n 24)

    No newline at end of file
    Open

        return {'draw_id': str(draw_id), 'graph_id': graph_id, 'owner_id': owner_id}
    Severity: Minor
    Found in app/tasks/enrichment_apps.py by pep8

    Trailing blank lines are superfluous.

    Okay: spam(1)
W391: spam(1)\n

However the last line should end with a new line (warning W292).

    Line too long (80 > 79 characters)
    Open

        return {'draw_id': str(draw_id), 'graph_id': graph_id, 'owner_id': owner_id}
    Severity: Minor
    Found in app/tasks/enrichment_apps.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    There are no issues that match your filters.

    Category
    Status