maestro-server/data-app

View on GitHub
app/controller/dcSnapshots.py

Summary

Maintainability
A
35 mins
Test Coverage
B
80%

Similar blocks of code found in 20 locations. Consider refactoring.
Open

Severity: Major
Found in app/controller/dcSnapshots.py and 19 other locations - About 35 mins to fix
app/controller/dcAdminer.py on lines 0..120
app/controller/dcApplications.py on lines 0..124
app/controller/dcClients.py on lines 0..124
app/controller/dcConnections.py on lines 0..124
app/controller/dcDatacenter.py on lines 0..124
app/controller/dcEvents.py on lines 0..124
app/controller/dcFlavors.py on lines 0..124
app/controller/dcFlavorsPublic.py on lines 0..118
app/controller/dcGraphs.py on lines 0..124
app/controller/dcImages.py on lines 0..124
app/controller/dcNetwork.py on lines 0..124
app/controller/dcProjects.py on lines 0..124
app/controller/dcReports.py on lines 0..124
app/controller/dcSchedulers.py on lines 0..124
app/controller/dcServers.py on lines 0..124
app/controller/dcServices.py on lines 0..124
app/controller/dcSystem.py on lines 0..124
app/controller/dcTeams.py on lines 0..124
app/controller/dcVolumes.py on lines 0..124

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line too long (133 > 79 characters)
Open

    @apiDescription Look like te same of get action, if you need to do a long filters likes a list of ids, you can use this endpoint.
Severity: Minor
Found in app/controller/dcSnapshots.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

Line too long (115 > 79 characters)
Open

    @apiParam {Array} body List of batches data, if exist _id this item only be updated, otherwise will be created.
Severity: Minor
Found in app/controller/dcSnapshots.py by pep8

Limit all lines to a maximum of 79 characters.

There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

There are no issues that match your filters.

Category
Status