Sign upLogin

maestro-server/discovery-api

View on GitHub
Star
app/tasks/translate.py

Summary

Maintainability
A
1 hr
Test Coverage
F
29%

Function task_translate has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def task_translate(conn, conn_id, options, task, result, lasted=False):
Severity: Minor
Found in app/tasks/translate.py - About 45 mins to fix

    Function task_translate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def task_translate(conn, conn_id, options, task, result, lasted=False):

    if not isinstance(result, list):
        task_notification.delay(msg="[Translate] Empty result", conn_id=conn_id, task=task, status='warning')
        return {'task': task}
    Severity: Minor
    Found in app/tasks/translate.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Line too long (85 > 79 characters)
    Open

                key = task_insert.delay(conn, conn_id, task, translate, options, tlasted)
    Severity: Minor
    Found in app/tasks/translate.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (109 > 79 characters)
    Open

            task_notification.delay(msg="[Translate] Empty result", conn_id=conn_id, task=task, status='warning')
    Severity: Minor
    Found in app/tasks/translate.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (109 > 79 characters)
    Open

            task_notification.delay(msg="[Translate] Empty result", conn_id=conn_id, task=task, status='warning')
    Severity: Minor
    Found in app/tasks/translate.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    No newline at end of file
    Open

        }
    Severity: Minor
    Found in app/tasks/translate.py by pep8

    Trailing blank lines are superfluous.

    Okay: spam(1)
W391: spam(1)\n

However the last line should end with a new line (warning W292).

    Line too long (107 > 79 characters)
    Open

            tlasted = lasted and GenerateTranslate.isLast()  # lasted of result and lasted of IteratorTranslate
    Severity: Minor
    Found in app/tasks/translate.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (103 > 79 characters)
    Open

                tkey = task_tracker.delay(translate, conn['dc_id'], conn['region'], task, conn_id, options)
    Severity: Minor
    Found in app/tasks/translate.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    There are no issues that match your filters.

    Category
    Status