Sign upLogin

maestro-server/discovery-api

View on GitHub
Star

Showing 598 of 598 total issues

Function batch has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def batch(self, items, Ruler, source={}):
        for key, item in items:
            res = getattr(Ruler, item.get('call'))(item.get('source'), source)

            if isinstance(res, dict):
Severity: Minor
Found in app/services/iterators/iRuler.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function task_tracker has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

def task_tracker(result, dc_id, region, task, accountant, options):
Severity: Minor
Found in app/tasks/tracker.py - About 45 mins to fix

    Function iterTranslate has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def iterTranslate(conn, conn_id, options, task, result, tlasted):
    Severity: Minor
    Found in app/tasks/scan.py - About 45 mins to fix

      Function entity_count has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def entity_count(dc_id, owner, region, accountant, resources, options):
      Severity: Minor
      Found in app/tasks/helpers/last.py - About 45 mins to fix

        Function task_scan has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def task_scan(conn, conn_id, task, options, lasted=False, vars=[]):
        Severity: Minor
        Found in app/tasks/scan.py - About 45 mins to fix

          Function make_query has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def make_query(dc_id, owner, region, accountant, resources, options):
          Severity: Minor
          Found in app/tasks/helpers/last.py - About 45 mins to fix

            Function task_translate has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def task_translate(conn, conn_id, options, task, result, lasted=False):
            Severity: Minor
            Found in app/tasks/translate.py - About 45 mins to fix

              Function get_data_list has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def get_data_list(result, key, owner_user, conn_id, entity):
              Severity: Minor
              Found in app/tasks/insert.py - About 35 mins to fix

                Function merger_with has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    def merger_with(self, obj_value, src_value, key, obj, source):
                Severity: Minor
                Found in app/services/merge/merge_rules.py - About 35 mins to fix

                  Function spawnScan has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      def spawnScan(self, connector, region, task, commands, lasted):
                  Severity: Minor
                  Found in app/controller/crawlerApp.py - About 35 mins to fix

                    Function iterTranslate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def iterTranslate(conn, conn_id, options, task, result, tlasted):
    if isinstance(result, list):
        return task_translate.delay(conn, conn_id, options, task, result, tlasted)

    if isinstance(result, GeneratorType):
                    Severity: Minor
                    Found in app/tasks/scan.py - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    if json:
                    tf_filter = filtering(json, self._opts.get('filter'))
                    results = results + tf_filter
                    Severity: Minor
                    Found in app/repository/providers/terraform/auth_s3.py and 1 other location - About 35 mins to fix
                    app/repository/providers/terraform/auth_ssh.py on lines 15..18

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 33.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                                    if json:

                    tf_filter = filtering(json, self._opts.get('filter'))
                    results = results + tf_filter
                    Severity: Minor
                    Found in app/repository/providers/terraform/auth_ssh.py and 1 other location - About 35 mins to fix
                    app/repository/providers/terraform/auth_s3.py on lines 19..21

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 33.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function configure has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def configure(self):
        "Write configuration changes to the Linksys."
        if self.actions:
            fields = []
            self.cache_flush()
                    Severity: Minor
                    Found in share/doc/pycurl/examples/linksys.py - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function crawlerFactory has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                    Open

                        def crawlerFactory(self, instance, task, require):
        connector = ExternalMaestroData()\
                        .list_request(path="connections/%s" % instance)\
                        .get_results()
                    Severity: Minor
                    Found in app/controller/crawlerApp.py - About 35 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this function.
                    Open

                            return json.JSONEncoder.default(self, obj)
                    Severity: Major
                    Found in app/libs/jsonEncoder.py - About 30 mins to fix

                      Function ipv4 has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def ipv4(obj, conn, len):
        Crawler = HookedAzure.createConn(conn)
        options = {
            "access": "network_interfaces",
            "command": "network",
                      Severity: Minor
                      Found in app/repository/providers/azure/hooks.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function switch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def switch(source, batch, default=None, capitalize=False):
        fields = source.split('|')
        for field in fields:
            result = get(batch, field)
            if result:
                      Severity: Minor
                      Found in app/services/rules/ruler.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function task_insert has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      def task_insert(conn, conn_id, task, result, options, lasted=False):

    key_comparer = get(options, 'key_comparer')
    owner_user = get(conn, 'owner_user._id')
                      Severity: Minor
                      Found in app/tasks/insert.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function fctPublicIp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def fctPublicIp(source, batch):
        ip = None
        dirts = Ruler.switch(source, batch, {})

        if dirts:
                      Severity: Minor
                      Found in app/repository/providers/openstack/rules.py - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language