Sign upLogin

maestro-server/scheduler-app

View on GitHub
Star
app/tasks/connections.py

Summary

Maintainability
A
1 hr
Test Coverage
F
0%

Function task_connections has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def task_connections(name, _id, endpoint, source='discovery', method="GET", args={}, chain=[]):
Severity: Major
Found in app/tasks/connections.py - About 50 mins to fix

    Function task_connections has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def task_connections(name, _id, endpoint, source='discovery', method="GET", args={}, chain=[]):
    msg = "Task Connection - %s" % _id

    try:
        connType = re.search(r'/[a-zA-Z0-9]{24,24}/([a-z-]*)$', endpoint).group(1)
    Severity: Minor
    Found in app/tasks/connections.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if resource.get_status() >= 400:
        msg = resource.get_error()
        task_deplete.delay(msg, _id)
    Severity: Minor
    Found in app/tasks/connections.py and 1 other location - About 35 mins to fix
    app/tasks/reports.py on lines 26..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 33.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Line too long (93 > 79 characters)
    Open

                webhook_id = task_webhook.delay(name, _id, endpoint, source, method, args, chain)
    Severity: Minor
    Found in app/tasks/connections.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    Line too long (95 > 79 characters)
    Open

    def task_connections(name, _id, endpoint, source='discovery', method="GET", args={}, chain=[]):
    Severity: Minor
    Found in app/tasks/connections.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    No newline at end of file
    Open

        return {'msg': msg, 'status_code': resource.get_status()}
    Severity: Minor
    Found in app/tasks/connections.py by pep8

    Trailing blank lines are superfluous.

    Okay: spam(1)
W391: spam(1)\n

However the last line should end with a new line (warning W292).

    Line too long (82 > 79 characters)
    Open

            connType = re.search(r'/[a-zA-Z0-9]{24,24}/([a-z-]*)$', endpoint).group(1)
    Severity: Minor
    Found in app/tasks/connections.py by pep8

    Limit all lines to a maximum of 79 characters.

    There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

    There are no issues that match your filters.

    Category
    Status