magarcia/repolar-parse

View on GitHub

Showing 13 of 13 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  while (index < length) {
    prev = character;
    character = value.charAt(index);

    if (character === marker && !whitespace(prev)) {
Severity: Major
Found in lib/tokenize/emphasis/index.ts and 1 other location - About 1 day to fix
lib/tokenize/strong/index.ts on lines 31..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 197.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  while (index < length) {
    prev = character;
    character = value.charAt(index);

    if (character === marker && !whitespace(prev)) {
Severity: Major
Found in lib/tokenize/strong/index.ts and 1 other location - About 1 day to fix
lib/tokenize/emphasis/index.ts on lines 32..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 197.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function underline has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function underline(eat: EatType, value: string) {
  const self = this;
  let index = 0;
  let character = value.charAt(index);
  let now;
Severity: Minor
Found in lib/tokenize/underline/index.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function emphasis has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function emphasis(eat: EatType, value: string) {
  const self = this;
  let index = 0;
  let character = value.charAt(index);
  let now;
Severity: Minor
Found in lib/tokenize/emphasis/index.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function strong has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function strong(eat: EatType, value: string) {
  const self = this;
  let index = 1;
  let character = value.charAt(0);
  let now;
Severity: Minor
Found in lib/tokenize/strong/index.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function underline has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function underline(eat: EatType, value: string) {
  const self = this;
  let index = 0;
  let character = value.charAt(index);
  let now;
Severity: Minor
Found in lib/tokenize/underline/index.ts - About 1 hr to fix

    Function highlight has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function highlight(eat: EatType, value: string) {
      const self = this;
      let character = "";
      let previous = "";
      let preceding = "";
    Severity: Minor
    Found in lib/tokenize/highlight/index.ts - About 1 hr to fix

      Function emphasis has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function emphasis(eat: EatType, value: string) {
        const self = this;
        let index = 0;
        let character = value.charAt(index);
        let now;
      Severity: Minor
      Found in lib/tokenize/emphasis/index.ts - About 1 hr to fix

        Function strong has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function strong(eat: EatType, value: string) {
          const self = this;
          let index = 1;
          let character = value.charAt(0);
          let now;
        Severity: Minor
        Found in lib/tokenize/strong/index.ts - About 1 hr to fix

          Function strikethrough has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

          function strikethrough(eat: EatType, value: string) {
            const self = this;
            let character = "";
            let previous = "";
            let preceding = "";
          Severity: Minor
          Found in lib/tokenize/strikethrough/index.ts - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function strikethrough has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function strikethrough(eat: EatType, value: string) {
            const self = this;
            let character = "";
            let previous = "";
            let preceding = "";
          Severity: Minor
          Found in lib/tokenize/strikethrough/index.ts - About 1 hr to fix

            Consider simplifying this complex logical expression.
            Open

                if (
                  ((whitespace(character) && previous === marker) ||
                    (character === marker && isLastCharacter)) &&
                  (!preceding || !whitespace(preceding))
                ) {
            Severity: Major
            Found in lib/tokenize/strikethrough/index.ts - About 40 mins to fix

              Function highlight has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              function highlight(eat: EatType, value: string) {
                const self = this;
                let character = "";
                let previous = "";
                let preceding = "";
              Severity: Minor
              Found in lib/tokenize/highlight/index.ts - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language