Sign upLogin

magento-hackathon/Magento-Two-factor-Authentication

View on GitHub
Star
src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php

Summary

Maintainability
F
3 days
Test Coverage

Function qrSubmitAction has a Cognitive Complexity of 55 (exceeds 5 allowed). Consider refactoring.
Open

    public function qrSubmitAction()
    {
        if ( ! $this->getRequest()->isPost()) {
            return;
        }
Severity: Minor
Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File TwofactorauthController.php has 369 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

/**
 * adminhtml controller to enforce Two Factor Authentication
 *
Severity: Minor
Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 4 hrs to fix

    Method qrSubmitAction has 94 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function qrSubmitAction()
    {
        if ( ! $this->getRequest()->isPost()) {
            return;
        }
    Severity: Major
    Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 3 hrs to fix

      Method resetAction has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function resetAction()
    {
        if ( ! Mage::helper('twofactorauth/auth')->isReAuthenticated()) {
            $this->_getSession()->addError($this->__('Access Denied.'));
            $this->_redirectReferer();
      Severity: Minor
      Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 1 hr to fix

        Method answerAction has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function answerAction()
    {
        $questionId = (int) Mage::app()->getRequest()->getPost('question_id');
        if ( ! $questionId) {
            $this->_redirect('*/*/interstitial');
        Severity: Minor
        Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 1 hr to fix

          Function _isAllowed has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              protected function _isAllowed()
    {
        $action = $this->getRequest()->getActionName();

        if ($action == 'resetUser') {
          Severity: Minor
          Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return;
          Severity: Major
          Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return FALSE;
            Severity: Major
            Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return;
              Severity: Major
              Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return;
                Severity: Major
                Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return;
                  Severity: Major
                  Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                    return;
                    Severity: Major
                    Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return TRUE;
                      Severity: Major
                      Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return;
                        Severity: Major
                        Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return ($hasToken && $authenticated);
                          Severity: Major
                          Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 30 mins to fix

                            Function answerAction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                public function answerAction()
    {
        $questionId = (int) Mage::app()->getRequest()->getPost('question_id');
        if ( ! $questionId) {
            $this->_redirect('*/*/interstitial');
                            Severity: Minor
                            Found in src/app/code/community/MageHackDay/TwoFactorAuth/controllers/Adminhtml/TwofactorauthController.php - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            There are no issues that match your filters.

                            Category
                            Status