Sign upLogin

magickatt/MultiContextBDDTalk

View on GitHub
Star
backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php

Summary

Maintainability
A
0 mins
Test Coverage

Showing 11 of 11 total issues

Avoid excessively long variable names like $locationAndYearRangeRoute. Keep variable name length under 20.
Open

        $locationAndYearRangeRoute = function (Application $application, $locationId, $yearFrom, $yearTo = null) {
Severity: Minor
Found in backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php by phpmd

Avoid excessively long variable names like $locationPairAndYearRoute. Keep variable name length under 20.
Open

        $locationPairAndYearRoute = function (Application $application, $location1Id, $location2Id, $year) {
Severity: Minor
Found in backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php by phpmd

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

        });
Severity: Minor
Found in backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

        };
Severity: Minor
Found in backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

        };
Severity: Minor
Found in backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php by phpcodesniffer

Function closing brace must go on the next line following the body; found 1 blank lines before brace
Open

        });
Severity: Minor
Found in backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php by phpcodesniffer

Line exceeds 120 characters; contains 130 characters
Open

            return $responseService->createEntryAggregateSummaryCollectionResponse(new EntryAggregateSummaryCollection($entries));
Severity: Minor
Found in backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php by phpcodesniffer

Line exceeds 120 characters; contains 128 characters
Open

    protected function registerControllerRoutes(Application $application, ControllerCollection $collection):ControllerCollection
Severity: Minor
Found in backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php by phpcodesniffer

Line exceeds 120 characters; contains 130 characters
Open

            return $responseService->createEntryAggregateSummaryCollectionResponse(new EntryAggregateSummaryCollection($entries));
Severity: Minor
Found in backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php by phpcodesniffer

Line exceeds 120 characters; contains 153 characters
Open

            $entries = $entryService->getEntryListByLocationAndYearRange($location, (int)$yearFrom, (!is_null($yearTo) ? (int)$yearTo : (int)$yearFrom));
Severity: Minor
Found in backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php by phpcodesniffer

Line exceeds 120 characters; contains 130 characters
Open

            return $responseService->createEntryAggregateSummaryCollectionResponse(new EntryAggregateSummaryCollection($entries));
Severity: Minor
Found in backend/src/HistoricalMeteorological/Provider/Controller/EntryControllerProvider.php by phpcodesniffer

There are no issues that match your filters.

Category
Status