Sign upLogin

magickatt/MultiContextBDDTalk

View on GitHub
Star
backend/src/HistoricalMeteorological/Service/ResponseService.php

Summary

Maintainability
A
0 mins
Test Coverage

Showing 8 of 8 total issues

Avoid using static access to class '\HistoricalMeteorological\Transformer\EntrySummaryTransformer' in method 'createEntryAggregateSummaryCollectionResponse'.
Open

            'meta' => EntrySummaryTransformer::transformEntrySummaryToArray($summary),
Severity: Minor
Found in backend/src/HistoricalMeteorological/Service/ResponseService.php by phpmd

Avoid using static access to class '\HistoricalMeteorological\Calculator\EntryCollectionSummaryCalculator' in method 'createEntryComparisonSummaryCollectionResponse'.
Open

        $summaryComparison = EntryCollectionSummaryCalculator::compareEntryCollections($collection1, $collection2);
Severity: Minor
Found in backend/src/HistoricalMeteorological/Service/ResponseService.php by phpmd

Avoid using static access to class '\HistoricalMeteorological\Transformer\EntrySummaryTransformer' in method 'createEntryComparisonSummaryCollectionResponse'.
Open

            'meta' => EntrySummaryTransformer::transformEntrySummaryComparisonToArray($summaryComparison),
Severity: Minor
Found in backend/src/HistoricalMeteorological/Service/ResponseService.php by phpmd

Avoid using static access to class '\HistoricalMeteorological\Transformer\LocationTransformer' in method 'createLocationResponse'.
Open

        return $this->createSingularResponse(LocationTransformer::transformLocationToArray($location), $responseCode);
Severity: Minor
Found in backend/src/HistoricalMeteorological/Service/ResponseService.php by phpmd

Avoid using static access to class '\HistoricalMeteorological\Calculator\EntryCollectionSummaryCalculator' in method 'createEntryAggregateSummaryCollectionResponse'.
Open

        $summary = EntryCollectionSummaryCalculator::summariseEntryCollection($collection, new EntrySummary());
Severity: Minor
Found in backend/src/HistoricalMeteorological/Service/ResponseService.php by phpmd

Avoid unused private methods such as 'createPluralResponse'.
Open

    private function createPluralResponse(CollectionInterface $collection, int $responseCode = 200)
    {
        return new JsonResponse(
            [
                'data' => $collection->toArray(),
Severity: Minor
Found in backend/src/HistoricalMeteorological/Service/ResponseService.php by phpmd

Line exceeds 120 characters; contains 135 characters
Open

            'data' => array_map(array(EntryTransformer::class, 'transformEntryToArray'), $collection1->merge($collection2)->toArray()),
Severity: Minor
Found in backend/src/HistoricalMeteorological/Service/ResponseService.php by phpcodesniffer

Line exceeds 120 characters; contains 122 characters
Open

    public function createEntryComparisonSummaryCollectionResponse(EntryComparisonSummaryCollection $comparisonCollection)
Severity: Minor
Found in backend/src/HistoricalMeteorological/Service/ResponseService.php by phpcodesniffer

There are no issues that match your filters.

Category
Status