The closing brace for the class must go on the next line after the body

Open

}

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at end of control structure

Open

• Exclude checks
  • Disable engine
  • Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace

Open

        };

• Exclude checks
  • Disable engine
  • Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace

Open

        });

• Exclude checks
  • Disable engine
  • Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace

Open

        };

• Exclude checks
  • Disable engine
  • Disable check

Blank line found at start of control structure

Open

            foreach ($this->parser->getEntries($rows) as $entry) {

• Exclude checks
  • Disable engine
  • Disable check

Function closing brace must go on the next line following the body; found 1 blank lines before brace

Open

        });

• Exclude checks
  • Disable engine
  • Disable check

Function convert has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    public function convert(SeekableIterator $location)
    {
        foreach ($this->loader->getResources($location) as $resource) {
            $rows = $this->loader->getRows($resource);
            foreach ($this->parser->getEntries($rows) as $entry) {

• Read up
  Read up

Function getFilesFromDirectory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

Open

    private function getFilesFromDirectory(DirectoryIterator $directory):Generator
    {
        if (!$directory->isDir() || !$directory->isReadable()) {
            throw new InvalidArgumentException('Directory is either not actually a directory or not accessible');
        }

• Read up
  Read up

Avoid unused parameters such as '$application'.

Open

        $collection->get('/', function (Application $application) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Avoid using static access to class '\HistoricalMeteorological\Transformer\EntrySummaryTransformer' in method 'createEntryAggregateSummaryCollectionResponse'.

Open

            'meta' => EntrySummaryTransformer::transformEntrySummaryToArray($summary),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

The method getEntries uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Open

            } else {
                $queryBuilder->andWhere('e.year = :yearFrom');
            }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Avoid unused private methods such as 'createPluralResponse'.

Open

    private function createPluralResponse(CollectionInterface $collection, int $responseCode = 200)
    {
        return new JsonResponse(
            [
                'data' => $collection->toArray(),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Avoid using static access to class '\HistoricalMeteorological\Calculator\EntryCollectionSummaryCalculator' in method 'createEntryComparisonSummaryCollectionResponse'.

Open

        $summaryComparison = EntryCollectionSummaryCalculator::compareEntryCollections($collection1, $collection2);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Avoid using static access to class '\HistoricalMeteorological\Transformer\EntrySummaryTransformer' in method 'createEntryComparisonSummaryCollectionResponse'.

Open

            'meta' => EntrySummaryTransformer::transformEntrySummaryComparisonToArray($summaryComparison),

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Avoid using static access to class '\HistoricalMeteorological\Transformer\LocationTransformer' in method 'createLocationResponse'.

Open

        return $this->createSingularResponse(LocationTransformer::transformLocationToArray($location), $responseCode);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Avoid using static access to class '\HistoricalMeteorological\Calculator\EntryCollectionSummaryCalculator' in method 'createEntryAggregateSummaryCollectionResponse'.

Open

        $summary = EntryCollectionSummaryCalculator::summariseEntryCollection($collection, new EntrySummary());

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 130 characters

Open

            return $responseService->createEntryAggregateSummaryCollectionResponse(new EntryAggregateSummaryCollection($entries));

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 128 characters

Open

    protected function registerControllerRoutes(Application $application, ControllerCollection $collection):ControllerCollection

• Exclude checks
  • Disable engine
  • Disable check

Line exceeds 120 characters; contains 133 characters

Open

    public static function compareEntryCollections(EntryCollection $collection1, EntryCollection $collection2):EntrySummaryComparison

• Exclude checks
  • Disable engine
  • Disable check