Sign upLogin

magoosh/motion_record

View on GitHub
Star

Showing 4 of 4 total issues

Class Scope has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Scope

    attr_reader :klass
    attr_reader :conditions
Severity: Minor
Found in lib/motion_record/scope.rb - About 2 hrs to fix

    Method sql_options has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

          def sql_options
        sql_options = []

        @options.each do |key, value|
          case key
    Severity: Minor
    Found in lib/motion_record/schema/column_definition.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method predicate_segments has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def predicate_segments
      unless @predicate_segments
        @predicate_segments = []
        if condition_columns.any?
          @predicate_segments << "WHERE #{condition_columns.map { |c| "#{c} = ? " }.join " AND "}"
    Severity: Minor
    Found in lib/motion_record/scope.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method deserialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def deserialize(value)
        if @column.type == :integer
          if value == 0 || value.nil?
            false
          else
    Severity: Minor
    Found in lib/motion_record/serialization/boolean_serializer.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language