Sign upLogin

mailup/mailup-ruby

View on GitHub
Star

Showing 4 of 4 total issues

Class List has 36 methods (exceeds 20 allowed). Consider refactoring.
Open

    class List
      attr_accessor :api

      def initialize(id, api)
        @api = api
Severity: Minor
Found in lib/mailup/console/list.rb - About 4 hrs to fix

    Method initialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def initialize(credentials=nil, debug=false)
      @debug = debug
      @host = 'https://services.mailup.com'
      @path = ''
      @credentials = credentials
    Severity: Minor
    Found in lib/mailup.rb - About 1 hr to fix

      Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(credentials=nil, debug=false)
      @debug = debug
      @host = 'https://services.mailup.com'
      @path = ''
      @credentials = credentials
      Severity: Minor
      Found in lib/mailup.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def request(method, path, opts={}, &block) # :nodoc:
      unless @access_token == nil
        # Refresh token if needed
        @access_token = @access_token.refresh! if @access_token.expired?
        # Ensure the body is JSON
      Severity: Minor
      Found in lib/mailup.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language