Sign upLogin

makeomatic/ms-payments

View on GitHub
Star
src/actions/agreement/execute.js

Summary

Maintainability
A
2 hrs
Test Coverage

Function agreementExecute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

async function agreementExecute({ params }) {
  const { config, redis, amqp } = this;
  const { token } = params;

  let agreementData;
Severity: Minor
Found in src/actions/agreement/execute.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function saveAgreement has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

async function saveAgreement(redis, token, agreement, owner, planId, creatorTaskId, finalizedAt) {
Severity: Major
Found in src/actions/agreement/execute.js - About 50 mins to fix

    Function fetchUpdatedAgreement has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    async function fetchUpdatedAgreement(paypalCfg, log, agreementId, owner, token, creatorTaskId) {
    Severity: Minor
    Found in src/actions/agreement/execute.js - About 45 mins to fix

      Parsing error: The keyword 'const' is reserved
      Open

      const { HttpStatusError } = require('common-errors');
      Severity: Minor
      Found in src/actions/agreement/execute.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status