Sign upLogin

maki-tetsu/anodator

View on GitHub
Star
lib/anodator/input_spec_item.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method has too many lines. [12/10]
Open

    def initialize(number, name, type = TYPE_STRING)
      if number.nil? || number.to_s.split(//).size.zero?
        raise ArgumentError, 'number cannot be blank'
      end
      if name.nil? || name.to_s.split(//).size.zero?
Severity: Minor
Found in lib/anodator/input_spec_item.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for initialize is too high. [15.17/15]
Open

    def initialize(number, name, type = TYPE_STRING)
      if number.nil? || number.to_s.split(//).size.zero?
        raise ArgumentError, 'number cannot be blank'
      end
      if name.nil? || name.to_s.split(//).size.zero?
Severity: Minor
Found in lib/anodator/input_spec_item.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method initialize has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def initialize(number, name, type = TYPE_STRING)
      if number.nil? || number.to_s.split(//).size.zero?
        raise ArgumentError, 'number cannot be blank'
      end
      if name.nil? || name.to_s.split(//).size.zero?
Severity: Minor
Found in lib/anodator/input_spec_item.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing top-level class documentation comment.
Open

  class InputSpecItem
Severity: Minor
Found in lib/anodator/input_spec_item.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

There are no issues that match your filters.

Category
Status