maki-tetsu/anodator

View on GitHub
lib/anodator/output_spec.rb

Summary

Maintainability
C
1 day
Test Coverage

Class has too many lines. [143/100]
Open

  class OutputSpec
    TARGET_DATA  = 'DATA'.freeze
    TARGET_ERROR = 'ERROR'.freeze

    VALID_SYMBOL_ITEMS = %i[
Severity: Minor
Found in lib/anodator/output_spec.rb by rubocop

This cop checks if the length a class exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [55/10]
Open

    def generate_error(input_spec_with_values, check_results)
      buf = []

      if check_results.size.zero?
        if @include_no_error
Severity: Minor
Found in lib/anodator/output_spec.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method generate_error has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    def generate_error(input_spec_with_values, check_results)
      buf = []

      if check_results.size.zero?
        if @include_no_error
Severity: Minor
Found in lib/anodator/output_spec.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Assignment Branch Condition size for generate_error is too high. [39.94/15]
Open

    def generate_error(input_spec_with_values, check_results)
      buf = []

      if check_results.size.zero?
        if @include_no_error
Severity: Minor
Found in lib/anodator/output_spec.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method has too many lines. [22/10]
Open

    def generate_data(input_spec_with_values, check_results)
      buf = []
      buf << @items.map do |item|
        if item.is_a? Symbol
          case item
Severity: Minor
Found in lib/anodator/output_spec.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [21/10]
Open

    def initialize(items = [], options = {})
      @items            = items.to_a
      @target           = TARGET_ERROR
      @include_no_error = false
      @separator        = ' '
Severity: Minor
Found in lib/anodator/output_spec.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for generate_error is too high. [16/6]
Open

    def generate_error(input_spec_with_values, check_results)
      buf = []

      if check_results.size.zero?
        if @include_no_error
Severity: Minor
Found in lib/anodator/output_spec.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Perceived complexity for generate_error is too high. [13/7]
Open

    def generate_error(input_spec_with_values, check_results)
      buf = []

      if check_results.size.zero?
        if @include_no_error
Severity: Minor
Found in lib/anodator/output_spec.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Method generate_error has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def generate_error(input_spec_with_values, check_results)
      buf = []

      if check_results.size.zero?
        if @include_no_error
Severity: Major
Found in lib/anodator/output_spec.rb - About 2 hrs to fix

    Assignment Branch Condition size for generate_data is too high. [17.12/15]
    Open

        def generate_data(input_spec_with_values, check_results)
          buf = []
          buf << @items.map do |item|
            if item.is_a? Symbol
              case item
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

    Cyclomatic complexity for generate_data is too high. [7/6]
    Open

        def generate_data(input_spec_with_values, check_results)
          buf = []
          buf << @items.map do |item|
            if item.is_a? Symbol
              case item
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Method generate_data has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def generate_data(input_spec_with_values, check_results)
          buf = []
          buf << @items.map do |item|
            if item.is_a? Symbol
              case item
    Severity: Minor
    Found in lib/anodator/output_spec.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Block has too many lines. [34/25]
    Open

            check_results.each do |check_result|
              buf << @items.map do |item|
                if item.is_a? Symbol
                  case item
                  when :target_numbers
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Block has too many lines. [32/25]
    Open

              buf << @items.map do |item|
                if item.is_a? Symbol
                  case item
                  when :target_numbers
                    next check_result.target_numbers.join(@separator)
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    This cop checks if the length of a block exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable. The cop can be configured to ignore blocks passed to certain methods.

    Method check_items has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def check_items
          @items.each do |item|
            next unless item.is_a? Symbol
            unless VALID_SYMBOL_ITEMS.include?(item)
              raise ArgumentError, "unknown item symbol #{item}"
    Severity: Minor
    Found in lib/anodator/output_spec.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid more than 3 levels of block nesting.
    Open

                      result.warning? ? true : nil
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    This cop checks for excessive nesting of conditional and looping constructs.

    You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

    The maximum level of nesting allowed is configurable.

    Avoid more than 3 levels of block nesting.
    Open

                      result.error? ? true : nil
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    This cop checks for excessive nesting of conditional and looping constructs.

    You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

    The maximum level of nesting allowed is configurable.

    Avoid more than 3 levels of block nesting.
    Open

                  case item
                  when :error_count, :warning_count, :error_and_warning_count
                    next '0'
                  else
                    next ''
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    This cop checks for excessive nesting of conditional and looping constructs.

    You can configure if blocks are considered using the CountBlocks option. When set to false (the default) blocks are not counted towards the nesting level. Set to true to count blocks as well.

    The maximum level of nesting allowed is configurable.

    Use a guard clause instead of wrapping the code inside a conditional expression.
    Open

            if item.is_a? Symbol
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    Use a guard clause instead of wrapping the code inside a conditional expression

    Example:

    # bad
    def test
      if something
        work
      end
    end
    
    # good
    def test
      return unless something
      work
    end
    
    # also good
    def test
      work if something
    end
    
    # bad
    if something
      raise 'exception'
    else
      ok
    end
    
    # good
    raise 'exception' if something
    ok

    Avoid the use of double negation (!!).
    Open

              @include_no_error = !!opt
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

    Example:

    # bad
    !!something
    
    # good
    !something.nil?

    Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

    Use a guard clause instead of wrapping the code inside a conditional expression.
    Open

                if item.is_a? Symbol
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    Use a guard clause instead of wrapping the code inside a conditional expression

    Example:

    # bad
    def test
      if something
        work
      end
    end
    
    # good
    def test
      return unless something
      work
    end
    
    # also good
    def test
      work if something
    end
    
    # bad
    if something
      raise 'exception'
    else
      ok
    end
    
    # good
    raise 'exception' if something
    ok

    Use a guard clause instead of wrapping the code inside a conditional expression.
    Open

                if item.is_a? Symbol
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    Use a guard clause instead of wrapping the code inside a conditional expression

    Example:

    # bad
    def test
      if something
        work
      end
    end
    
    # good
    def test
      return unless something
      work
    end
    
    # also good
    def test
      work if something
    end
    
    # bad
    if something
      raise 'exception'
    else
      ok
    end
    
    # good
    raise 'exception' if something
    ok

    Missing top-level class documentation comment.
    Open

      class OutputSpec
    Severity: Minor
    Found in lib/anodator/output_spec.rb by rubocop

    This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

    The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

    Example:

    # bad
    class Person
      # ...
    end
    
    # good
    # Description/Explanation of Person class
    class Person
      # ...
    end

    There are no issues that match your filters.

    Category
    Status