Sign upLogin

maki-tetsu/anodator

View on GitHub
Star
lib/anodator/validator/complex_validator.rb

Summary

Maintainability
A
55 mins
Test Coverage

Method has too many lines. [17/10]
Open

      def validate
        if @options[:validators].nil?
          raise ConfigurationError, 'ComplexValidator must have validators option'
        end
        case @options[:logic]
Severity: Minor
Found in lib/anodator/validator/complex_validator.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method validate has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def validate
        if @options[:validators].nil?
          raise ConfigurationError, 'ComplexValidator must have validators option'
        end
        case @options[:logic]
Severity: Minor
Found in lib/anodator/validator/complex_validator.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Useless assignment to variable - buf. Use + instead of +=.
Open

        buf += @options[:validators].map do |validator|
Severity: Minor
Found in lib/anodator/validator/complex_validator.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Line is too long. [82/80]
Open

          raise ConfigurationError, 'ComplexValidator must have validators option'
Severity: Minor
Found in lib/anodator/validator/complex_validator.rb by rubocop

There are no issues that match your filters.

Category
Status