Sign upLogin

maki-tetsu/anodator

View on GitHub
Star
lib/anodator/validator/value_proxy.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method has too many lines. [15/10]
Open

      def initialize(value, validator)
        @value = value
        @validator = validator
        @indirect = false
        @data_source = false
Severity: Minor
Found in lib/anodator/validator/value_proxy.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

      def value
        if indirect?
          if data_source?
            @validator.data_source_at(@value[0].value,
                                      @value[1].value,
Severity: Minor
Found in lib/anodator/validator/value_proxy.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Missing top-level class documentation comment.
Open

    class ValueProxy
Severity: Minor
Found in lib/anodator/validator/value_proxy.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Use a guard clause instead of wrapping the code inside a conditional expression.
Open

        if matched = REGEXP_DATA_SOURCE.match(@value.to_s)
Severity: Minor
Found in lib/anodator/validator/value_proxy.rb by rubocop

Use a guard clause instead of wrapping the code inside a conditional expression

Example:

# bad
def test
  if something
    work
  end
end

# good
def test
  return unless something
  work
end

# also good
def test
  work if something
end

# bad
if something
  raise 'exception'
else
  ok
end

# good
raise 'exception' if something
ok

Pass &:to_s as an argument to map instead of a block.
Open

          @value.map { |v| v.to_s }.join(':') + '(DataSource)'
Severity: Minor
Found in lib/anodator/validator/value_proxy.rb by rubocop

Use symbols as procs when possible.

Example:

# bad
something.map { |s| s.upcase }

# good
something.map(&:upcase)

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

        if matched = REGEXP_INDIRECT.match(@value.to_s)
Severity: Minor
Found in lib/anodator/validator/value_proxy.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
Open

        if matched = REGEXP_DATA_SOURCE.match(@value.to_s)
Severity: Minor
Found in lib/anodator/validator/value_proxy.rb by rubocop

This cop checks for assignments in the conditions of if/while/until.

Example:

# bad

if some_var = true
  do_something
end

Example:

# good

if some_var == true
  do_something
end

There are no issues that match your filters.

Category
Status