mambax7/adslight

View on GitHub
add.php

Summary

Maintainability
B
5 hrs
Test Coverage

File add.php has 289 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php declare(strict_types=1);

/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
Severity: Minor
Found in add.php - About 2 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if ('1' === $helper->getConfig('adslight_diff_name')) {
            $form->addElement(new \XoopsFormText(_ADSLIGHT_SUBMITTER, 'submitter', 50, 50, $member_uname), true);
        } else {
            $form->addElement(new \XoopsFormLabel(_ADSLIGHT_SUBMITTER, $member_uname));
            $form->addElement(new \XoopsFormHidden('submitter', $member_uname), true);
    Severity: Major
    Found in add.php and 3 other locations - About 1 hr to fix
    add.php on lines 256..261
    addlisting.php on lines 256..261
    addlisting.php on lines 262..267

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if ('1' === $helper->getConfig('adslight_diff_email')) {
            $form->addElement(new \XoopsFormText(_ADSLIGHT_EMAIL, 'email', 50, 50, $member_email), true);
        } else {
            $form->addElement(new \XoopsFormLabel(_ADSLIGHT_EMAIL, $member_email));
            $form->addElement(new \XoopsFormHidden('email', $member_email), true);
    Severity: Major
    Found in add.php and 3 other locations - About 1 hr to fix
    add.php on lines 250..255
    addlisting.php on lines 256..261
    addlisting.php on lines 262..267

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 102.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There must be one USE keyword per declaration
    Open

    use XoopsModules\Adslight\{
    Severity: Minor
    Found in add.php by phpcodesniffer

    Line exceeds 120 characters; contains 121 characters
    Open

            $sql                     = 'SELECT title FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE cid=' . $cid;
    Severity: Minor
    Found in add.php by phpcodesniffer

    Line exceeds 120 characters; contains 132 characters
    Open

                $form->addElement(new \XoopsFormText(_ADSLIGHT_HOW_LONG, 'expire', 3, 3, $helper->getConfig('adslight_howlong')), true);
    Severity: Minor
    Found in add.php by phpcodesniffer

    Line exceeds 120 characters; contains 321 characters
    Open

            "INSERT INTO `%s` (lid, cid, title, STATUS, EXPIRE, type, desctext, tel, price, typeprice, typecondition, date_created, email, submitter, usid, town, country, contactby, premium, valid) VALUES (%u, '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s', '%s')",
    Severity: Minor
    Found in add.php by phpcodesniffer

    Line exceeds 120 characters; contains 126 characters
    Open

            $mail->setTemplateDir(XOOPS_ROOT_PATH . '/modules/adslight/language/' . $xoopsConfig['language'] . '/mail_template/');
    Severity: Minor
    Found in add.php by phpcodesniffer

    Line exceeds 120 characters; contains 168 characters
    Open

            //        $form->addElement(new \XoopsFormEditor(_ADSLIGHT_DESC, $helper->getConfig('adslightEditorUser'), $options, $nohtml = FALSE, $onfailure = 'textarea'));
    Severity: Minor
    Found in add.php by phpcodesniffer

    Spaces must be used to indent lines; tabs are not allowed
    Open

            $options           = [];
    Severity: Minor
    Found in add.php by phpcodesniffer

    Line exceeds 120 characters; contains 145 characters
    Open

            $sql      = 'SELECT title, cat_moderate FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid='" . $xoopsDB->escape($cid) . "'";
    Severity: Minor
    Found in add.php by phpcodesniffer

    Line exceeds 120 characters; contains 126 characters
    Open

        $sql3    = 'SELECT id_condition, nom_condition FROM ' . $xoopsDB->prefix('adslight_condition') . ' ORDER BY id_condition';
    Severity: Minor
    Found in add.php by phpcodesniffer

    Line indented incorrectly; expected 8 spaces, found 9
    Open

             if ($xoopsDB->isResultSet($result2)) {
    Severity: Minor
    Found in add.php by phpcodesniffer

    Closing brace indented incorrectly; expected 9 spaces, found 8
    Open

            }
    Severity: Minor
    Found in add.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status