mambax7/adslight

View on GitHub
admin/category.php

Summary

Maintainability
D
2 days
Test Coverage

adsModCat accesses the super-global variable $GLOBALS.
Open

function adsModCat($cid): void
{
    global $xoopsDB, $myts;
    $helper = Helper::getInstance();
    $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
Severity: Minor
Found in admin/category.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

adsModCat accesses the super-global variable $GLOBALS.
Open

function adsModCat($cid): void
{
    global $xoopsDB, $myts;
    $helper = Helper::getInstance();
    $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
Severity: Minor
Found in admin/category.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method adsModCat has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function adsModCat($cid): void
{
    global $xoopsDB, $myts;
    $helper = Helper::getInstance();
    $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
Severity: Major
Found in admin/category.php - About 3 hrs to fix

    File category.php has 302 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php declare(strict_types=1);
    
    /*
     * You may not change or alter any portion of this comment or credits
     * of supporting developers from this source code or any supporting source code
    Severity: Minor
    Found in admin/category.php - About 3 hrs to fix

      Function adsModCat has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

      function adsModCat($cid): void
      {
          global $xoopsDB, $myts;
          $helper = Helper::getInstance();
          $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
      Severity: Minor
      Found in admin/category.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method adsNewCat has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function adsNewCat($cid): void
      {
          global $xoopsDB, $myts;
          $helper = Helper::getInstance();
          $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
      Severity: Major
      Found in admin/category.php - About 2 hrs to fix

        Function adsNewCat has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

        function adsNewCat($cid): void
        {
            global $xoopsDB, $myts;
            $helper = Helper::getInstance();
            $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
        Severity: Minor
        Found in admin/category.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method adsModCatS has 10 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            $cidd,
            $cid,
            $img,
            $title,
            $cat_desc,
        Severity: Major
        Found in admin/category.php - About 1 hr to fix

          Method adsAddCat has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              $title,
              $cat_desc,
              $cat_keywords,
              $cid,
              $img,
          Severity: Major
          Found in admin/category.php - About 1 hr to fix

            The function adsModCatS has 10 parameters. Consider reducing the number of parameters to less than 10.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            The function adsModCat() has 115 lines of code. Current threshold is set to 100. Avoid really long methods.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            The function adsModCat() has an NPath complexity of 6144. The configured NPath complexity threshold is 200.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            NPathComplexity

            Since: 0.1

            The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

            Example

            class Foo {
                function bar() {
                    // lots of complicated code
                }
            }

            Source https://phpmd.org/rules/codesize.html#npathcomplexity

            The function adsModCat() has a Cyclomatic Complexity of 16. The configured cyclomatic complexity threshold is 10.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
            class Foo {
            1   public function example() {
            2       if ($a == $b) {
            3           if ($a1 == $b1) {
                            fiddle();
            4           } elseif ($a2 == $b2) {
                            fiddle();
                        } else {
                            fiddle();
                        }
            5       } elseif ($c == $d) {
            6           while ($c == $d) {
                            fiddle();
                        }
            7        } elseif ($e == $f) {
            8           for ($n = 0; $n < $h; $n++) {
                            fiddle();
                        }
                    } else {
                        switch ($z) {
            9               case 1:
                                fiddle();
                                break;
            10              case 2:
                                fiddle();
                                break;
            11              case 3:
                                fiddle();
                                break;
                            default:
                                fiddle();
                                break;
                        }
                    }
                }
            }

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            The function adsNewCat() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
            class Foo {
            1   public function example() {
            2       if ($a == $b) {
            3           if ($a1 == $b1) {
                            fiddle();
            4           } elseif ($a2 == $b2) {
                            fiddle();
                        } else {
                            fiddle();
                        }
            5       } elseif ($c == $d) {
            6           while ($c == $d) {
                            fiddle();
                        }
            7        } elseif ($e == $f) {
            8           for ($n = 0; $n < $h; $n++) {
                            fiddle();
                        }
                    } else {
                        switch ($z) {
            9               case 1:
                                fiddle();
                                break;
            10              case 2:
                                fiddle();
                                break;
            11              case 3:
                                fiddle();
                                break;
                            default:
                                fiddle();
                                break;
                        }
                    }
                }
            }

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            Avoid unused local variables such as '$a'.
            Open

                            $a = 1;
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$pid'.
            Open

                [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$key'.
            Open

                foreach ($filelist as $key => $file) {
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$affprice'.
            Open

                [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$cat_id'.
            Open

                [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$title'.
            Open

                [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$cat_moderate'.
            Open

                [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$moderate_subcat'.
            Open

                [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$myts'.
            Open

                global $xoopsDB, $myts;
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$myts'.
            Open

                global $xoopsDB, $myts;
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$a'.
            Open

                            $a = 1;
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$cat_id'.
            Open

                [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$imgs'.
            Open

                [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$key'.
            Open

                foreach ($filelist as $key => $file) {
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$myts'.
            Open

                global $xoopsDB, $myts;
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$myts'.
            Open

                global $xoopsDB, $myts;
            Severity: Minor
            Found in admin/category.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            The method adsNewCat uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                    } else {
                        echo "<option value=\"{$file}\">{$file}</option>";
                    }
            Severity: Minor
            Found in admin/category.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class '\XoopsModules\Adslight\Helper' in method 'adsModCat'.
            Open

                $helper = Helper::getInstance();
            Severity: Minor
            Found in admin/category.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method adsModCat uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                } else {
                    $cat_order = (int)$cat_order;
                    echo "<input type=\"hidden\" name=\"cat_order\" value=\"{$cat_order}\">";
                }
            Severity: Minor
            Found in admin/category.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class '\XoopsModules\Adslight\Helper' in method 'adsDelCat'.
            Open

                $helper = Helper::getInstance();
            Severity: Minor
            Found in admin/category.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class '\XoopsDatabaseFactory' in method 'adsDelCat'.
            Open

                    $xoopsDB = \XoopsDatabaseFactory::getDatabaseConnection();
            Severity: Minor
            Found in admin/category.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class '\Xmf\Request' in method 'adsNewCat'.
            Open

                $cid    = Request::getInt('cid', 0, 'GET');
            Severity: Minor
            Found in admin/category.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method adsNewCat uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                } else {
                    $cat_order = (int)$cat_order;
                    echo "<input type=\"hidden\" name=\"cat_order\" value=\"{$cat_order}\">";
                    echo '<tr><td class="foot" colspan=3><input type="submit" value="' . _AM_ADSLIGHT_ADD . '" ></td></tr>';
                }
            Severity: Minor
            Found in admin/category.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class '\XoopsModules\Adslight\Helper' in method 'adsAddCat'.
            Open

                $helper          = Helper::getInstance();
            Severity: Minor
            Found in admin/category.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method adsDelCat uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                } else {
                    //        require_once __DIR__ . '/admin_header.php';
                    //        loadModuleAdminMenu(1, '');
            
                    OpenTable();
            Severity: Minor
            Found in admin/category.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class '\XoopsModules\Adslight\Utility' in method 'adsNewCat'.
            Open

                Utility::showImage();
            Severity: Minor
            Found in admin/category.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class '\XoopsModules\Adslight\Utility' in method 'adsModCat'.
            Open

                Utility::showImage();
            Severity: Minor
            Found in admin/category.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method adsModCatS uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                } else {
                    $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . " SET cat_moderate=1, moderate_subcat=1 WHERE pid={$cidd}");
                }
            Severity: Minor
            Found in admin/category.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The method adsModCat uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                    } else {
                        echo "<option value=\"{$file}\">{$file}</option>";
                    }
            Severity: Minor
            Found in admin/category.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            Avoid using static access to class '\XoopsModules\Adslight\Helper' in method 'adsModCatS'.
            Open

                $helper = Helper::getInstance();
            Severity: Minor
            Found in admin/category.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class '\XoopsModules\Adslight\Helper' in method 'adsNewCat'.
            Open

                $helper = Helper::getInstance();
            Severity: Minor
            Found in admin/category.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
            {
                public function bar()
                {
                    Bar::baz();
                }
            }

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            The method adsAddCat uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
            Open

                } else {
                    $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . ' SET cat_moderate=0 WHERE pid = ' . (int)$cid);
                }
            Severity: Minor
            Found in admin/category.php by phpmd

            ElseExpression

            Since: 1.4.0

            An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

            Example

            class Foo
            {
                public function bar($flag)
                {
                    if ($flag) {
                        // one branch
                    } else {
                        // another branch
                    }
                }
            }

            Source https://phpmd.org/rules/cleancode.html#elseexpression

            The parameter $cat_order is not named in camelCase.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseParameterName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name parameters.

            Example

            class ClassName {
                public function doSomething($user_name) {
                }
            }

            Source

            The parameter $cat_moderate is not named in camelCase.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseParameterName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name parameters.

            Example

            class ClassName {
                public function doSomething($user_name) {
                }
            }

            Source

            The parameter $cat_order is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseParameterName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name parameters.

            Example

            class ClassName {
                public function doSomething($user_name) {
                }
            }

            Source

            The parameter $cat_desc is not named in camelCase.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseParameterName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name parameters.

            Example

            class ClassName {
                public function doSomething($user_name) {
                }
            }

            Source

            Avoid variables with short names like $a. Configured minimum length is 3.
            Open

                            $a = 1;
            Severity: Minor
            Found in admin/category.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            The parameter $cat_desc is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseParameterName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name parameters.

            Example

            class ClassName {
                public function doSomething($user_name) {
                }
            }

            Source

            Avoid variables with short names like $a. Configured minimum length is 3.
            Open

                            $a = 1;
            Severity: Minor
            Found in admin/category.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            The parameter $cat_keywords is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseParameterName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name parameters.

            Example

            class ClassName {
                public function doSomething($user_name) {
                }
            }

            Source

            The parameter $moderate_subcat is not named in camelCase.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseParameterName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name parameters.

            Example

            class ClassName {
                public function doSomething($user_name) {
                }
            }

            Source

            The parameter $cat_keywords is not named in camelCase.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseParameterName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name parameters.

            Example

            class ClassName {
                public function doSomething($user_name) {
                }
            }

            Source

            Avoid variables with short names like $ok. Configured minimum length is 3.
            Open

            function adsDelCat($cid, $ok = 0): void
            Severity: Minor
            Found in admin/category.php by phpmd

            ShortVariable

            Since: 0.2

            Detects when a field, local, or parameter has a very short name.

            Example

            class Something {
                private $q = 15; // VIOLATION - Field
                public static function main( array $as ) { // VIOLATION - Formal
                    $r = 20 + $this->q; // VIOLATION - Local
                    for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                        $r += $this->q;
                    }
                }
            }

            Source https://phpmd.org/rules/naming.html#shortvariable

            The parameter $cat_moderate is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseParameterName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name parameters.

            Example

            class ClassName {
                public function doSomething($user_name) {
                }
            }

            Source

            The parameter $moderate_subcat is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseParameterName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name parameters.

            Example

            class ClassName {
                public function doSomething($user_name) {
                }
            }

            Source

            A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 41 and the first side effect is on line 31.
            Open

            <?php declare(strict_types=1);
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            There must be one USE keyword per declaration
            Open

            use XoopsModules\Adslight\{
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 122 characters
            Open

                         . "    <input type=\"text\" name=\"cat_keywords\" value=\"{$cat_keywords}\" size=\"80\" maxlength=\"200\">\n"
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 251 characters
            Open

                echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_CAT . ' </td><td class="odd" colspan=2><input type="radio" name="cat_moderate" value="1"checked>' . _YES . '&nbsp;&nbsp; <input type="radio" name="cat_moderate" value="0">' . _NO . '</td></tr>';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 199 characters
            Open

                <td class="even">' . _AM_ADSLIGHT_CATNAME . "   </td><td class=\"odd\"><input type=\"text\" name=\"title\" value=\"{$title}\" size=\"50\" maxlength=\"100\">&nbsp; " . _AM_ADSLIGHT_IN . ' &nbsp;';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 139 characters
            Open

                    $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . " SET cat_moderate=1, moderate_subcat=1 WHERE pid={$cidd}");
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 148 characters
            Open

                echo "  <tr>\n" . '    <td class="even">' . _AM_ADSLIGHT_IMGCAT . '  </td><td class="odd" colspan=2><select name="img" onChange="showimage()">';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 147 characters
            Open

                [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 142 characters
            Open

                echo '<tr><td class="even">' . _AM_ADSLIGHT_DISPLPRICE2 . ' </td><td class="odd" colspan=2><input type="radio" name="affprice" value="1"';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 203 characters
            Open

                    echo '<tr><td>' . _AM_ADSLIGHT_ORDER . ' </td><td><input type="text" name="cat_order" size="4" value="0" ></td><td class="foot"><input type="submit" value="' . _AM_ADSLIGHT_ADD . '" ></td></tr>';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 190 characters
            Open

                $sql    = 'SELECT cid, pid, title, cat_desc, cat_keywords, img, cat_order, affprice, cat_moderate, moderate_subcat FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid={$cid}";
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 244 characters
            Open

                echo '</select>&nbsp;&nbsp;<img src="' . XOOPS_URL . '/modules/adslight/assets/images/img_cat/default.png" name="avatar" align="absmiddle"><br><b>' . _AM_ADSLIGHT_REPIMGCAT . '</b><br>../modules/adslight/assets/images/img_cat/..</td></tr>';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 245 characters
            Open

                echo '</select>&nbsp;&nbsp;<img src="' . XOOPS_URL . "/modules/adslight/assets/images/img_cat/{$imgs}\" name=\"avatar\" align=\"absmiddle\"><br><b>" . _AM_ADSLIGHT_REPIMGCAT . '</b><br>../modules/adslight/assets/images/img_cat/..</td></tr>';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 154 characters
            Open

                echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_SUBCATS . ' </td><td class="odd" colspan=2><input type="radio" name="moderate_subcat" value="1"';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 259 characters
            Open

                       . " SET title='{$title}', cat_desc='{$cat_desc}', cat_keywords='{$cat_keywords}', pid='{$cid}', img='{$img}', cat_order='{$cat_order}', affprice='{$affprice}', cat_moderate='{$cat_moderate}', moderate_subcat='{$moderate_subcat}' WHERE cid={$cidd}";
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 127 characters
            Open

                    $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . ' SET cat_moderate=0 WHERE pid = ' . (int)$cid);
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 180 characters
            Open

                  <td class="even">' . _AM_ADSLIGHT_CATNAME . ' </td><td class="odd" colspan=2><input type="text" name="title" size="50" maxlength="100">&nbsp; ' . _AM_ADSLIGHT_IN . ' &nbsp;';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 261 characters
            Open

                echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_SUBCATS . ' </td><td class="odd" colspan=2><input type="radio" name="moderate_subcat" value="1"checked>' . _YES . '&nbsp;&nbsp; <input type="radio" name="moderate_subcat" value="0">' . _NO . '</td></tr>';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 190 characters
            Open

                $sql    = 'SELECT cid, pid, title, cat_desc, cat_keywords, img, cat_order, affprice, cat_moderate, moderate_subcat FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid={$cid}";
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 134 characters
            Open

                    echo "[ <a href=\"category.php?op=AdsDelCat&cid={$cid}&ok=1\">" . _YES . '</a> | <a href="map.php">' . _NO . '</a> ]<br><br>';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 147 characters
            Open

                [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 147 characters
            Open

                echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_CAT . ' </td><td class="odd" colspan=2><input type="radio" name="cat_moderate" value="1"';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 171 characters
            Open

                    echo '<tr><td class="even">' . _AM_ADSLIGHT_ORDER . " </td><td class=\"odd\"><input type=\"text\" name=\"cat_order\" size=\"4\" value=\"{$cat_order}\"></td></tr>";
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 139 characters
            Open

                    $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . " SET cat_moderate=0, moderate_subcat=0 WHERE pid={$cidd}");
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 129 characters
            Open

                echo '<form method="post" action="category.php" name="imcat"><input type="hidden" name="op" value="AdsAddCat"></font><br><br>
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 225 characters
            Open

                $sql = 'INSERT INTO ' . $xoopsDB->prefix('adslight_categories') . " VALUES (NULL, '{$cid}', '{$title}', '{$cat_desc}', '{$cat_keywords}', '{$img}', '{$cat_order}', '{$affprice}', '{$cat_moderate}', '{$moderate_subcat}')";
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 276 characters
            Open

                echo '<tr><td class="even">' . _AM_ADSLIGHT_DISPLPRICE2 . ' </td><td class="odd" colspan=2><input type="radio" name="affprice" value="1" checked>' . _YES . '&nbsp;&nbsp; <input type="radio" name="affprice" value="0">' . _NO . ' (' . _AM_ADSLIGHT_INTHISCAT . ')</td></tr>';
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            Line exceeds 120 characters; contains 127 characters
            Open

                    $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . ' SET cat_moderate=1 WHERE pid = ' . (int)$cid);
            Severity: Minor
            Found in admin/category.php by phpcodesniffer

            The variable $cat_order is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $moderate_subcat is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_order is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_id is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_desc is not named in camelCase.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $moderate_subcat is not named in camelCase.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $moderate_subcat is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_order is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_order is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_order is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_keywords is not named in camelCase.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $moderate_subcat is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_desc is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_moderate is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_moderate is not named in camelCase.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_desc is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_desc is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_keywords is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_desc is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $moderate_subcat is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_desc is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_keywords is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $moderate_subcat is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $moderate_subcat is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $moderate_subcat is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_keywords is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_desc is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_order is not named in camelCase.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $moderate_subcat is not named in camelCase.
            Open

            function adsModCatS(
                $cidd,
                $cid,
                $img,
                $title,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_order is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_keywords is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_desc is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_id is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_keywords is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_order is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_desc is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_order is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_order is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_moderate is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_keywords is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $moderate_subcat is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_moderate is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_order is not named in camelCase.
            Open

            function adsNewCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_moderate is not named in camelCase.
            Open

            function adsModCat($cid): void
            {
                global $xoopsDB, $myts;
                $helper = Helper::getInstance();
                $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $cat_moderate is not named in camelCase.
            Open

            function adsAddCat(
                $title,
                $cat_desc,
                $cat_keywords,
                $cid,
            Severity: Minor
            Found in admin/category.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            There are no issues that match your filters.

            Category
            Status