Sign upLogin

mambax7/adslight

View on GitHub
Star
admin/upgrade.php

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (!Utility::checkTableExists($xoopsDB->prefix('adslight_replies'))) {
        $sql3 = 'CREATE TABLE ' . $xoopsDB->prefix('adslight_replies') . " (
      r_lid INT(11) NOT NULL AUTO_INCREMENT,
      lid INT(5) UNSIGNED NOT NULL DEFAULT '0',
      title VARCHAR(50) NOT NULL DEFAULT '',
Severity: Minor
Found in admin/upgrade.php and 1 other location - About 40 mins to fix
admin/upgrade.php on lines 39..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (!Utility::checkTableExists($xoopsDB->prefix('adslight_pictures'))) {
        $sql = 'CREATE TABLE ' . $xoopsDB->prefix('adslight_pictures') . " (
              cod_img INT(11) NOT NULL AUTO_INCREMENT,
              title VARCHAR(255) NOT NULL DEFAULT '',
              date_created INT(10)NOT NULL DEFAULT '0',
Severity: Minor
Found in admin/upgrade.php and 1 other location - About 40 mins to fix
admin/upgrade.php on lines 58..76

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There must be one blank line after the last USE statement; 0 found;
Open

use XoopsModules\Adslight\{
Severity: Minor
Found in admin/upgrade.php by phpcodesniffer

There must be one USE keyword per declaration
Open

use XoopsModules\Adslight\{
Severity: Minor
Found in admin/upgrade.php by phpcodesniffer

Line exceeds 120 characters; contains 124 characters
Open

        Utility::addField("moderate_subcat int(5) DEFAULT '0' AFTER cat_moderate", $xoopsDB->prefix('adslight_categories'));
Severity: Minor
Found in admin/upgrade.php by phpcodesniffer

Line exceeds 120 characters; contains 216 characters
Open

        echo constant("{$admin_lang}_UPDATECOMPLETE") . " - <a href='" . XOOPS_URL . "/modules/system/admin.php?fct=modulesadmin&op=update&module={$moduleDirName}'>" . constant("{$admin_lang}_UPDATEMODULE") . '</a>';
Severity: Minor
Found in admin/upgrade.php by phpcodesniffer

There are no issues that match your filters.

Category
Status