Sign upLogin

mambax7/adslight

View on GitHub
Star
class/Common/Migrate.php

Summary

Maintainability
A
25 mins
Test Coverage

Function renameColumns has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    private function renameColumns(): void
    {
        $tables = new Tables();
        foreach ($this->renameColumns as $table) {
            $tableName   = $table['tablename'];
Severity: Minor
Found in class/Common/Migrate.php - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Missing class import via use statement (line '41', column '23').
Open

            throw new \RuntimeException("Class '$class' not found");
Severity: Minor
Found in class/Common/Migrate.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Line exceeds 120 characters; contains 128 characters
Open

                    //                    $tables->getTableIndexes()  update($tableName, [$newName => "($newName)"], '', false);
Severity: Minor
Found in class/Common/Migrate.php by phpcodesniffer

There are no issues that match your filters.

Category
Status