Sign upLogin

mambax7/adslight

View on GitHub
Star
class/Form/CategoriesForm.php

Summary

Maintainability
C
1 day
Test Coverage

Method __construct has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($target)
    {
        $this->helper       = $target->helper;
        $this->targetObject = $target;
Severity: Major
Found in class/Form/CategoriesForm.php - About 2 hrs to fix

    Function __construct has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct($target)
    {
        $this->helper       = $target->helper;
        $this->targetObject = $target;
    Severity: Minor
    Found in class/Form/CategoriesForm.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The class CategoriesForm has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
    Open

    class CategoriesForm extends \XoopsThemeForm
{
    public $targetObject;
    public $helper;
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    CouplingBetweenObjects

    Since: 1.1.0

    A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

    Example

    class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

    Source https://phpmd.org/rules/design.html#couplingbetweenobjects

    Missing class import via use statement (line '99', column '35').
    Open

                    $descEditor = new \XoopsFormEditor(\AM_ADSLIGHT_CATEGORIES_CAT_DESC, $this->helper->getConfig('adslightEditorAdmin'), $editorOptions, $nohtml = false, $onfailure = 'textarea');
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '123', column '28').
    Open

            $fileseltray = new \XoopsFormElementTray('', '<br>');
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '122', column '34').
    Open

            $imgtray->addElement(new \XoopsFormLabel('', "<br><img src='" . XOOPS_URL . '/' . $uploadDir . '/' . $img . "' name='image_img' id='image_img' alt='' style='max-width:300px' >"));
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '64', column '31').
    Open

            $this->addElement(new \XoopsFormLabel(\AM_ADSLIGHT_CATEGORIES_CID, $this->targetObject->getVar('cid'), 'cid'));
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '86', column '31').
    Open

            $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_CATEGORIES_TITLE, 'title', 50, 255, $this->targetObject->getVar('title')), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '129', column '31').
    Open

            $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_CATEGORIES_CAT_ORDER, 'cat_order', 50, 255, $this->targetObject->getVar('cat_order')), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '135', column '31').
    Open

            $this->addElement(new \XoopsFormSelectUser(\AM_ADSLIGHT_CATEGORIES_MODERATE_SUBCAT, 'moderate_subcat', false, $this->targetObject->getVar('moderate_subcat'), 1, false), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '131', column '31').
    Open

            $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_CATEGORIES_AFFPRICE, 'affprice', 50, 255, $this->targetObject->getVar('affprice')), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '59', column '23').
    Open

            $hidden = new \XoopsFormHidden('cid', $this->targetObject->getVar('cid'));
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '113', column '28').
    Open

            $imgtray     = new \XoopsFormElementTray(\AM_ADSLIGHT_CATEGORIES_IMG, '<br>');
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '138', column '31').
    Open

            $this->addElement(new \XoopsFormButton('', 'submit', \_SUBMIT, 'submit'));
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '137', column '31').
    Open

            $this->addElement(new \XoopsFormHidden('op', 'save'));
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '101', column '35').
    Open

                    $descEditor = new \XoopsFormEditor(\AM_ADSLIGHT_CATEGORIES_CAT_DESC, $this->helper->getConfig('adslightEditorUser'), $editorOptions, $nohtml = false, $onfailure = 'textarea');
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '104', column '31').
    Open

                $descEditor = new \XoopsFormDhtmlTextArea(\AM_ADSLIGHT_CATEGORIES_CAT_DESC, 'description', $this->targetObject->getVar('description', 'e'), 5, 50);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '133', column '31').
    Open

            $this->addElement(new \XoopsFormSelectUser(\AM_ADSLIGHT_CATEGORIES_CAT_MODERATE, 'cat_moderate', false, $this->targetObject->getVar('cat_moderate'), 1, false), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '75', column '33').
    Open

                $categoryTree = new \XoopsObjectTree($categoryArray, 'cid', 'pid');
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '108', column '31').
    Open

            $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_CATEGORIES_CAT_KEYWORDS, 'cat_keywords', 50, 255, $this->targetObject->getVar('cat_keywords')), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '124', column '38').
    Open

            $fileseltray->addElement(new \XoopsFormFile(\AM_ADSLIGHT_FORMUPLOAD, 'img', $this->helper->getConfig('maxsize')));
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '115', column '28').
    Open

            $imageselect = new \XoopsFormSelect($imgpath, 'img', $img);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '125', column '38').
    Open

            $fileseltray->addElement(new \XoopsFormLabel(''));
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '72', column '30').
    Open

            $criteria      = new \CriteriaCompo();
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\XoopsLists' in method '__construct'.
    Open

            $imageArray  = \XoopsLists::getImgListAsArray(XOOPS_ROOT_PATH . $uploadDir);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

                } else {
                $descEditor = new \XoopsFormEditor(\AM_ADSLIGHT_CATEGORIES_CAT_DESC, $this->helper->getConfig('adslightEditorUser'), $editorOptions, $nohtml = false, $onfailure = 'textarea');
            }
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $descEditor = new \XoopsFormDhtmlTextArea(\AM_ADSLIGHT_CATEGORIES_CAT_DESC, 'description', $this->targetObject->getVar('description', 'e'), 5, 50);
        }
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid unused local variables such as '$onfailure'.
    Open

                    $descEditor = new \XoopsFormEditor(\AM_ADSLIGHT_CATEGORIES_CAT_DESC, $this->helper->getConfig('adslightEditorAdmin'), $editorOptions, $nohtml = false, $onfailure = 'textarea');
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$nohtml'.
    Open

                    $descEditor = new \XoopsFormEditor(\AM_ADSLIGHT_CATEGORIES_CAT_DESC, $this->helper->getConfig('adslightEditorAdmin'), $editorOptions, $nohtml = false, $onfailure = 'textarea');
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            if (\class_exists('XoopsFormEditor')) {
            $editorOptions           = [];
            $editorOptions['name']   = 'cat_desc';
            $editorOptions['value']  = $this->targetObject->getVar('cat_desc', 'e');
            $editorOptions['rows']   = 5;
    Severity: Major
    Found in class/Form/CategoriesForm.php and 2 other locations - About 1 day to fix
    class/Form/ListingForm.php on lines 91..108
    class/Form/RepliesForm.php on lines 81..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 249.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 38 and the first side effect is on line 27.
    Open

    <?php declare(strict_types=1);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 134 characters
    Open

                //      $categoriesPid = $categoryTree->makeSelBox( 'pid', 'title','--', $this->targetObject->getVar('pid', 'e' ), true );
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 140 characters
    Open

            $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_CATEGORIES_TITLE, 'title', 50, 255, $this->targetObject->getVar('title')), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 191 characters
    Open

                    $descEditor = new \XoopsFormEditor(\AM_ADSLIGHT_CATEGORIES_CAT_DESC, $this->helper->getConfig('adslightEditorUser'), $editorOptions, $nohtml = false, $onfailure = 'textarea');
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 187 characters
    Open

            $imgtray->addElement(new \XoopsFormLabel('', "<br><img src='" . XOOPS_URL . '/' . $uploadDir . '/' . $img . "' name='image_img' id='image_img' alt='' style='max-width:300px' >"));
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 122 characters
    Open

            $fileseltray->addElement(new \XoopsFormFile(\AM_ADSLIGHT_FORMUPLOAD, 'img', $this->helper->getConfig('maxsize')));
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 161 characters
    Open

            $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_CATEGORIES_CAT_KEYWORDS, 'cat_keywords', 50, 255, $this->targetObject->getVar('cat_keywords')), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 162 characters
    Open

                $categoriesPid = $categoryTree->makeSelectElement('pid', 'title', '--', $this->targetObject->getVar('pid'), true, 0, '', \AM_ADSLIGHT_CATEGORIES_PID);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 125 characters
    Open

                //$this->addElement( new \XoopsFormEditor(AM_ADSLIGHT_CATEGORIES_CAT_DESC, 'cat_desc', $editorOptions), false  );
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 152 characters
    Open

            $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_CATEGORIES_CAT_ORDER, 'cat_order', 50, 255, $this->targetObject->getVar('cat_order')), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 159 characters
    Open

                $descEditor = new \XoopsFormDhtmlTextArea(\AM_ADSLIGHT_CATEGORIES_CAT_DESC, 'description', $this->targetObject->getVar('description', 'e'), 5, 50);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 175 characters
    Open

            $this->addElement(new \XoopsFormSelectUser(\AM_ADSLIGHT_CATEGORIES_CAT_MODERATE, 'cat_moderate', false, $this->targetObject->getVar('cat_moderate'), 1, false), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 149 characters
    Open

            $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_CATEGORIES_AFFPRICE, 'affprice', 50, 255, $this->targetObject->getVar('affprice')), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 192 characters
    Open

                    $descEditor = new \XoopsFormEditor(\AM_ADSLIGHT_CATEGORIES_CAT_DESC, $this->helper->getConfig('adslightEditorAdmin'), $editorOptions, $nohtml = false, $onfailure = 'textarea');
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 134 characters
    Open

            $imageselect->setExtra("onchange='showImgSelected(\"image_img\", \"img\", \"" . $uploadDir . '", "", "' . XOOPS_URL . "\")'");
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    Line exceeds 120 characters; contains 184 characters
    Open

            $this->addElement(new \XoopsFormSelectUser(\AM_ADSLIGHT_CATEGORIES_MODERATE_SUBCAT, 'moderate_subcat', false, $this->targetObject->getVar('moderate_subcat'), 1, false), false);
    Severity: Minor
    Found in class/Form/CategoriesForm.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status