mambax7/adslight

View on GitHub
class/Form/IplogForm.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '64', column '31').
Open

        $this->addElement(new \XoopsFormLabel(\AM_ADSLIGHT_IPLOG_IP_ID, $this->targetObject->getVar('ip_id'), 'ip_id'));
Severity: Minor
Found in class/Form/IplogForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '59', column '23').
Open

        $hidden = new \XoopsFormHidden('ip_id', $this->targetObject->getVar('ip_id'));
Severity: Minor
Found in class/Form/IplogForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '75', column '31').
Open

        $this->addElement(new \XoopsFormDateTime(\AM_ADSLIGHT_IPLOG_DATE_CREATED, 'date_created', 0, $this->targetObject->getVar('date_created')));
Severity: Minor
Found in class/Form/IplogForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '77', column '31').
Open

        $this->addElement(new \XoopsFormSelectUser(\AM_ADSLIGHT_IPLOG_SUBMITTER, 'submitter', false, $this->targetObject->getVar('submitter'), 1, false), false);
Severity: Minor
Found in class/Form/IplogForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '81', column '31').
Open

        $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_IPLOG_EMAIL, 'email', 50, 255, $this->targetObject->getVar('email')), false);
Severity: Minor
Found in class/Form/IplogForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '83', column '31').
Open

        $this->addElement(new \XoopsFormHidden('op', 'save'));
Severity: Minor
Found in class/Form/IplogForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '79', column '31').
Open

        $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_IPLOG_IPNUMBER, 'ipnumber', 50, 255, $this->targetObject->getVar('ipnumber')), false);
Severity: Minor
Found in class/Form/IplogForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '71', column '34').
Open

        $listing_id_select = new \XoopsFormSelect(\AM_ADSLIGHT_IPLOG_LID, 'lid', $this->targetObject->getVar('lid'));
Severity: Minor
Found in class/Form/IplogForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '84', column '31').
Open

        $this->addElement(new \XoopsFormButton('', 'submit', \_SUBMIT, 'submit'));
Severity: Minor
Found in class/Form/IplogForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 38 and the first side effect is on line 27.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in class/Form/IplogForm.php by phpcodesniffer

Line exceeds 120 characters; contains 161 characters
Open

        $this->addElement(new \XoopsFormSelectUser(\AM_ADSLIGHT_IPLOG_SUBMITTER, 'submitter', false, $this->targetObject->getVar('submitter'), 1, false), false);
Severity: Minor
Found in class/Form/IplogForm.php by phpcodesniffer

Line exceeds 120 characters; contains 147 characters
Open

        $this->addElement(new \XoopsFormDateTime(\AM_ADSLIGHT_IPLOG_DATE_CREATED, 'date_created', 0, $this->targetObject->getVar('date_created')));
Severity: Minor
Found in class/Form/IplogForm.php by phpcodesniffer

Line exceeds 120 characters; contains 144 characters
Open

        $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_IPLOG_IPNUMBER, 'ipnumber', 50, 255, $this->targetObject->getVar('ipnumber')), false);
Severity: Minor
Found in class/Form/IplogForm.php by phpcodesniffer

Line exceeds 120 characters; contains 135 characters
Open

        $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_IPLOG_EMAIL, 'email', 50, 255, $this->targetObject->getVar('email')), false);
Severity: Minor
Found in class/Form/IplogForm.php by phpcodesniffer

The variable $listing_id_select is not named in camelCase.
Open

    public function __construct($target)
    {
        $this->helper       = $target->helper;
        $this->targetObject = $target;

Severity: Minor
Found in class/Form/IplogForm.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $listing_id_select is not named in camelCase.
Open

    public function __construct($target)
    {
        $this->helper       = $target->helper;
        $this->targetObject = $target;

Severity: Minor
Found in class/Form/IplogForm.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $listing_id_select is not named in camelCase.
Open

    public function __construct($target)
    {
        $this->helper       = $target->helper;
        $this->targetObject = $target;

Severity: Minor
Found in class/Form/IplogForm.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status