mambax7/adslight

View on GitHub
class/Form/PriceForm.php

Summary

Maintainability
C
1 day
Test Coverage

Missing class import via use statement (line '64', column '31').
Open

        $this->addElement(new \XoopsFormLabel(\AM_ADSLIGHT_PRICE_ID_PRICE, $this->targetObject->getVar('id_price'), 'id_price'));
Severity: Minor
Found in class/Form/PriceForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '59', column '23').
Open

        $hidden = new \XoopsFormHidden('id_price', $this->targetObject->getVar('id_price'));
Severity: Minor
Found in class/Form/PriceForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '66', column '31').
Open

        $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_PRICE_NOM_PRICE, 'nom_price', 50, 255, $this->targetObject->getVar('nom_price')), false);
Severity: Minor
Found in class/Form/PriceForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '69', column '31').
Open

        $this->addElement(new \XoopsFormButton('', 'submit', \_SUBMIT, 'submit'));
Severity: Minor
Found in class/Form/PriceForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Missing class import via use statement (line '68', column '31').
Open

        $this->addElement(new \XoopsFormHidden('op', 'save'));
Severity: Minor
Found in class/Form/PriceForm.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php declare(strict_types=1);

namespace XoopsModules\Adslight\Form;

/*
Severity: Major
Found in class/Form/PriceForm.php and 1 other location - About 1 day to fix
class/Form/ConditionForm.php on lines 1..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 345.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 38 and the first side effect is on line 27.
Open

<?php declare(strict_types=1);
Severity: Minor
Found in class/Form/PriceForm.php by phpcodesniffer

Line exceeds 120 characters; contains 129 characters
Open

        $this->addElement(new \XoopsFormLabel(\AM_ADSLIGHT_PRICE_ID_PRICE, $this->targetObject->getVar('id_price'), 'id_price'));
Severity: Minor
Found in class/Form/PriceForm.php by phpcodesniffer

Line exceeds 120 characters; contains 147 characters
Open

        $this->addElement(new \XoopsFormText(\AM_ADSLIGHT_PRICE_NOM_PRICE, 'nom_price', 50, 255, $this->targetObject->getVar('nom_price')), false);
Severity: Minor
Found in class/Form/PriceForm.php by phpcodesniffer

There are no issues that match your filters.

Category
Status